Repository navigation
fix(insights): keep conflicting measurements private - #851
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@greptile review Please review the current head |
|
c52b899 to
b92c890
Compare
|
The latest updates on your projects. Learn more about Unkey Deploy
|
Comments Outside DiffThese findings sit on lines the diff does not cover, so they could not be posted inline. Each one leaves this list once its file changes.
|
Problem and behavior
A native goal or funnel read can cover fewer days than requested. The completion gate marks the investigation incomplete, but the agent can still publish the original full-period comparison, including by omitting the contradictory read from its citations.
Reject published product outcomes when successful original-population native reads, or cited same-subject diagnostic reads, contradict requested measurement dates, website, definition, or the evaluated definition across periods. The agent can return a private limitation using actual coverage. Independently inspected definition repairs remain allowed. This is an explicit metadata/definition contradiction veto, not a general numerical claim verifier.
Validation
Scope and overlaps
Independent slice from current
staging(020c04133), with no dependency on another feature branch. Overlaps #850 inapps/insights/src/agent.tsandSPEC.md, and #751 in the same agent/spec surface. #850 fixes funnel-step completion; this PR fixes publication validation. #849 changes selection separately. No model/prompt, completion, action/check, persistence, billing, schema or deployment change.AI-assisted implementation and review; draft for maintainer review.
Current CI: all 19 contexts finished (18 successful, one neutral); no actionable inline threads or submitted reviews. Configured code review is incomplete: CodeRabbit skipped automatic review and cubic reached its monthly quota. The PR remains draft; no merge or production deployment.