Repository navigation
test(insights): close review gaps from #864 and #851 - #967
Conversation
|
The latest updates on your projects. Learn more about Unkey Deploy
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closes two Greptile findings on merged PRs.
rankBusinessContext, so the new ranking path inresume.tshad no coverage. Adds one case toresume-clarification.integration.test.ts. It drives an analysis reply whose business context exceeds the budget through the real ranker with a fake Jev evaluator, then checks four things. The ranked sources (profile, reply, home, exception) reach the analysis and are saved in the observation'scontextSnapshot.trackAgentUsagerecords thetypesafe-ai/jevusage (103 tokens) under the reply's org, website and chatId. The reply succeeds. The native hold is confirmed (reserved 1, confirmed 1, released 0).investigation-flow.test.tsnow use plain if/else. Behavior is unchanged.Verification
apps/insights:check-typesclean,bun run test764 pass / 0 failINSIGHTS_INTEGRATION_TESTS=true bun test --isolate src/resume-clarification.integration.test.ts: 8 pass / 0 failresume.tsdisabled, the new case fails (the analysis receivesdecorationin place ofexception)biome checkclean on both filesSummary by cubic
Closes two test-coverage gaps found in review of #864 and #851.
trackAgentUsagerecording, and native hold state.investigation-flow.test.tswith plain if/else, without changing behavior.Verification
check-typesclean, 764 unit tests pass, the integration suite passes, and the new case fails when ranking is disabled;biome checkclean.Written for commit db0e0b4. Summary will update on new commits.