Skip to content

fix(insights): scope missing business descriptions precisely - #860

Merged
izadoesdev merged 1 commit into
stagingfrom
codex/insights-context-wording
Sep 27, 2026
Merged

izadoesdev merged 1 commit into
stagingfrom
codex/insights-context-wording

Conversation

@izadoesdev

@izadoesdev izadoesdev commented Sep 21, 2026 •

Copy link
Copy Markdown
Member

An empty goal or funnel description only establishes that the saved definition has no description. Narrow that generated context sentence so it does not imply the business has no configured purpose. Also let the brief summary add a supported control or scope limit, reducing pressure to invent a consequence.

This changes two lines across the shared definition formatter and agent writing instruction. It changes no measurement, completion, validation, or publication rule. The definition formatter serves fresh and remeasured goal/funnel/step signals.

Validation:

  • Root lint, type checks (33 tasks), and tests (29 tasks) pass; Insights has 692 passing tests and 6 skipped live tests.
  • Eight frozen synthetic trials compared a zero-count goal with unknown purpose and an inspected current target mismatch, twice per arm. Candidate accepted 4/4 outcomes versus baseline 3/4. Both arms kept both unknown-purpose cases private; useful current-target repairs were retained in 2/2 candidate versus 1/2 baseline outcomes.
  • This is an instruction-clarity improvement, not a demonstrated general quality or speed win. One candidate omitted the exact date range; another overstated historical causation despite a supported current repair. Mean elapsed time was 13.390s versus 14.026s, too small to claim faster performance. All eight initial finish attempts omitted a required citation name and needed correction.

This remains a draft with those semantic limitations. No live production evaluation of this wording change has run.

Based directly on current staging. No feature dependencies. Known overlaps: #849, #850, #851, and #751 touch Insights agent or business-context behavior. This slice changes only the two sentences described above.

AI assistance: Codex implemented and reviewed the change and ran the checks and synthetic evaluations. Human review remains pending.


Summary by cubic

Narrows the wording for missing business descriptions so an empty goal or funnel description no longer implies the business has no configured purpose. Also lets the summary add a supported control or scope limit, reducing pressure to invent a consequence.

  • Changes only two lines: the shared definition formatter's fallback text and the agent's writing instruction.
  • No measurement, completion, validation, or publication rules change; behavior remains otherwise identical.

Written for commit 49ef7d2. Summary will update on new commits.

Review in cubic

@vercel

vercel Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
databuddy-status Ready Ready Preview Sep 27, 2026 4:07pm UTC
2 Skipped Deployments
Project Deployment Actions Updated
dashboard Skipped Skipped Sep 27, 2026 4:07pm UTC
documentation Skipped Skipped Sep 27, 2026 4:07pm UTC

@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 3a961fae-26f8-4a66-ac0a-aff40426f4dc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@izadoesdev

Copy link
Copy Markdown
Member Author

@greptile review

Please review the current head 581f5178cef8ff7773f628eb8226f1c8dea96647 for correctness, security, and regressions as part of the requested review of all open PRs. This PR should remain a draft; this request is for review only.

@greptile-apps

greptile-apps Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Changes prompt text for an insights analysis agent.

This PR appears safe to merge.

Summary

The PR narrows what a missing goal or funnel description says about business purpose and allows an Insights summary to state a supported control or scope limit instead of a consequence.

  • No measurement, validation, or publication logic changes.

Reviews (2) · Last reviewed commit: "fix(insights): scope missing business de..."

@unkey-deploy

unkey-deploy Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Unkey Deploy

Name Status Preview Inspect Updated (UTC)
links (preview) Ready Visit Preview Inspect Sep 27, 2026 4:07pm

@izadoesdev
izadoesdev marked this pull request as ready for review September 27, 2026 16:10
@izadoesdev
izadoesdev merged commit ea87437 into staging Sep 27, 2026
21 checks passed
@izadoesdev
izadoesdev deleted the codex/insights-context-wording branch September 27, 2026 16:18

This branch was successfully deployed

2 active and 2 inactive deployments
Preview – databuddy-status — 49ef7d23 Deployed Sep 27, 2026 by vercel[bot]
links - preview — 49ef7d23 Deployed Sep 27, 2026 by unkey-deploy[bot]
Preview – documentation — 49ef7d23 Deployed Sep 27, 2026 by vercel[bot]
Preview – dashboard — 49ef7d23 Deployed Sep 27, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant