Repository navigation
fix(insights): complete measured funnel-step investigations - #850
Conversation
|
The latest updates on your projects. Learn more about Unkey Deploy
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@greptile review Please review the current head |
|
45338a6 to
bfe4b02
Compare
Funnel-step investigations with valid native measurements were always marked incomplete: the completion gate excluded
funnel_step, and its citation filter expected the nonexistentget_funnel_step_analyticstool. Resolve the validated parent/step and accept the existing parent funnel analytics only when both exact comparison windows establish that step's population.The gate checks tenant, definition, filters, unique predecessor/target rows, ordered counts, native two-decimal conversion and endpoint totals. It rejects clipped or conflicting reads from either window, including earlier uncited reads. Step conversion uses the preceding step's visitors, not the whole-funnel entrant count. Definition actions, saved verification checks, publication validation and billing rules are unchanged; supported step findings can now complete and follow the existing charge settlement path.
Validation:
A fresh bounded synthetic native-agent comparison completed all eight attempts on September 21 using unchanged detector input/prompt and identical tools. Full-window native completion improved 0/2 to 2/2; useful full-window findings were already 2/2 in both arms. Both versions still published unsupported clipped-window comparisons despite remaining incomplete, exposing a separate publication-validation defect. This PR adds no model calls or prompt instructions, and no speed or overall usefulness gain was demonstrated (aggregate observed time 49.238s baseline versus 54.053s candidate, with mocked tool I/O). The prior Gateway-failed round is preserved separately. Keep draft while the publication defect is addressed and maintainer review remains pending.
Scope/dependencies: independent slice based on current
staging; no dependency on an unmerged PR. #751 overlapsagent.tsandSPEC.mdfor business context and should be rechecked before landing. #849 is the separate Jev selector experiment; this PR does not include its selector or the rejected funnel-objective/revenue/claim-veto experiments.AI disclosure: Codex implemented the fix, ran checks and conducted automated review. Human maintainer verification remains pending.
Current remote checks: 18 successful contexts and one neutral, with no pending or failed contexts. Configured review has not completed: CodeRabbit skipped auto-review, and cubic reached its monthly quota. All general comments/reviews/threads were read; there is no actionable code feedback.
The separate publication failure is addressed by draft #851, an independent slice from staging. Its frozen eight-run confirmation retained full-window publication 2/2 in both arms and changed correctly private clipped results from 0/2 to 2/2. It does not depend on this completion fix.