Repository navigation
fix(insights): allow self-hosted analysis replies - #852
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Unkey Deploy
|
|
cddc681 to
88557fb
Compare
|
@greptile review Please review final head 88557fb after the test cleanup and rebase onto staging. The original feedback is addressed and all local checks passed. |
Summary
With
SELFHOST=true, starting a new analysis from an existing investigation was accepted by the API but failed in the worker because it required hosted billing terms. Skip that reservation block only in self-host mode; hosted instances withSELFHOSTunset orfalseretain the existing billing checks.Validation
bun run lintpassed, including 26 policy tests.bun run check-typespassed all 33 tasks.false, andtruemodes. The self-host case fails on the previous implementation and passes with this fix; hosted cases still reject unconfigured billing before analysis work.Tests used synthetic data and inert local service URLs. No live provider, production database, or deployment was used.
Scope and overlaps
Only the reply worker and its existing regression test change. #849, #850, and #851 also touch Insights, but their current file sets do not overlap this change. No dependency on those PRs.
Summary by cubic
Fixes failed analysis replies on self-hosted instances by skipping the hosted billing reservation when
SELFHOST=true.SELFHOSTunset orfalse) keep the existing billing checks.Written for commit 88557fb. Summary will update on new commits.