Repository navigation
Conversation
Needs you's technical details now list who answered each save of an item: a person in Run it or on their phone (signed in or not), or a named agent, rule or system with the first characters of the grant a person signed. A delegate row without a grant hash, on a person's route, or a phone answer without AAL2 reads as unverified, and rows that aren't answers are left out. Display only: what counts as approved is unchanged.
This was referenced Oct 18, 2026
Member
Author
|
Moved to the OpenAdapt monorepo, where openadapt-desktop now lives in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs you's technical details now include a Decided by list for each save of an item. Each entry is one of:
The engine projection (
approval_mode.item_approval) addsapprovers. It uses closed codes and opaque ids from Flow'sapprovalsrows; names and values never appear.Some rows are marked unverified, with "a person should look":
Rows that aren't answers are left out.
This is display only. What counts as approved, or as saved without a person, is unchanged. Delegate rows already exist on Flow main.
cloud_phonerows appear once Flow ships phone approval (OpenAdaptAI/OpenAdapt#1234); until then this reads the existing rows.Tests:
tests/test_engine/test_item_approvers.py(new) andsrc/lib/approvalMode.test.ts. Locally, ruff,tscand vitest pass.