Repository navigation
feat(desktop): show who decided each save, release 0.21.0 (hold: waits for publisher setup) - #1308
Merged
Merged
Conversation
Needs you's technical details now list who answered each save of an item: a person in Run it or on their phone (signed in or not), or a named agent, rule or system with the first characters of the grant a person signed. A delegate row without a grant hash, on a person's route, or a phone answer without AAL2 reads as unverified, and rows that aren't answers are left out. Display only: what counts as approved is unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready, but hold. Merging this PR starts the 0.21.0 release, and the founder approves that separately. The trusted publisher, the
pypi-desktopandnative-releaseenvironments and theopenadapt-desktop-v*tag rulesets are now set up. Merge this only after #1292 (the unified release workflow) is on main, and merge main into this branch again before merging. Keep it out of every merge queue.This ports OpenAdaptAI/openadapt-desktop#206 into
packages/desktop. That PR wasn't merged in openadapt-desktop because any merge there auto-publishes to PyPI.What it does
The technical details on the Needs you screen now include a Decided by list for each save of an item. Each entry is one of:
approval_mode.item_approvaladdsapprovers, built from closed codes and opaque ids in Flow'sapprovalsrows. Names and values never appear. These rows are marked unverified ("a person should look"):Rows that aren't answers are left out. This is display only: what counts as approved, or as saved without a person, doesn't change.
Commits
feat(approval): show who decided each saveandfix(approvers): …, carried over from the original branch withgit am -3 --directory=packages/desktop. Authorship and messages are unchanged.chore: release 0.21.0, written byscripts/prepare_release.py. It sets 0.21.0 inpyproject.toml,__init__,uv.lockand the five native version files, and adds the CHANGELOG section. That section also lists the two desktop fixes already on main that haven't been released yet.Base
#1281 is merged, so this PR is now based on
main. It still needs #1292 merged first, so thatdesktop-release.ymlon main is the unified release workflow.Tests
tests/test_engine/test_item_approvers.py(new) andtests/test_release_intent.pypass. So do the approval, release and version tests (167 passed).check_release_consistency.pyandcheck_release_intent.py --base origin/mainpass. ruff is clean.src/lib/approvalMode.test.tsruns in CI, not locally.🤖 Generated with Claude Code