Skip to content

docs(readme): the option table has the Skip opening row, so main's readme check passes - #2857

Closed
nullifyshot wants to merge 1 commit into
NotRexed:mainfrom
nullifyshot:docs/readme-skip-opening
Closed

nullifyshot wants to merge 1 commit into
NotRexed:mainfrom
nullifyshot:docs/readme-skip-opening

Conversation

@nullifyshot

Copy link
Copy Markdown
Contributor

tests/test_readme_menu_rows.py fails on main: the Gameplay tab's new Skip opening row (#2827) has no line in the readme's option table, which #2105 made list every row of the menu. The two merged close together, so neither saw the other.

  • Adds the Skip opening line to the option table, in the menu's order (after Discord status, before Bug report): Off / On, default Off, with what it skips as the row's help text says.
  • python -I -B tests/run_all.py readme_menu_rows: fails on main (menu rows with no line in readme.md's option table: ['Skip opening']), passes with this.
  • Full tests/run_all.py on Windows (llvm-mingw): 434 passed; the 4 failures (fpx_sticky, spawn_emit, bake_portability, lift_cache) fail on main here too.
  • Docs only, nothing in the game changes, so no game run.

Before opening I checked the 57 open PRs that edit readme.md and the 28 PRs merged since 16:30 UTC: none adds this line.

🤖 Generated with Claude Code

@nullifyshot
nullifyshot force-pushed the docs/readme-skip-opening branch from 29c7a45 to 30b304c Compare November 12, 2026 17:31
@nullifyshot

Copy link
Copy Markdown
Contributor Author

Rebased onto main dae1930 (still merges with 376d068); tests/test_readme_menu_rows.py passes on this branch and still fails on main. Overlap: #2561 (the docs rewrite) also adds a Skip opening line to the readme's option table. This one is the small fix for main's red check; if #2561 merges first, this can close. If this goes first, #2561 keeps its own wording on rebase.

…adme check passes

NotRexed#2827 added the Gameplay tab's Skip opening row and NotRexed#2105 made the readme's
option table list every row of the menu; they merged close together, so
tests/test_readme_menu_rows.py fails on main with "menu rows with no line in
readme.md's option table: Skip opening".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@nullifyshot
nullifyshot force-pushed the docs/readme-skip-opening branch from 30b304c to edf69f7 Compare November 12, 2026 17:44
@Arkex-ai

Copy link
Copy Markdown
Contributor

Applied the README-only delta at edf69f77 over main 65a4d874 and ran main's tests/test_readme_menu_rows.py: all 5 checks pass. Clean main fails 2 checks because the Skip opening row is missing and the order differs.

This checks the patch against main's actual menu/test inputs. Full suites, native builds and gameplay were not run for this review.

@mooki000

Copy link
Copy Markdown
Contributor

Tested on Linux: with this merged onto main 65a4d874, tests/test_readme_menu_rows.py passes again, all 5 cases (head edf69f77). On plain main the same file fails 2 of them (Skip opening has no line, and the order check).

For whoever merges: main has two more red source checks today, test_program_cache_one_variant.py (#2861 fixes it) and, on Windows only, test_wb_shadow_remake.py (a fix is coming as its own pull request).

@nullifyshot

Copy link
Copy Markdown
Contributor Author

Closing in favor of #2883.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants