Repository navigation
test(saves): cover newest-first directory order in the late-link case - #2888
Merged
Merged
Conversation
Make half the absolute links before save/ is created and half after. Both creation-order and newest-first directory listings now visit a link after its target has moved. Keep every existing link assertion. Refs NotRexed#2832 Assisted-by: GPT-6 Astra Co-Authored-By: GPT-6 Astra <noreply@openai.com>
mooki000
force-pushed
the
test/saves-move-link-order
branch
from
November 12, 2026 18:42
2bf8e7c to
789cb05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is for: keep the late-link regression from #2832 effective on both creation-order and newest-first directory listings, as its author asked for on that pull request (the review found the same weak spot).
What changed
In the case "a link to an entry that moves too", half of the 36 absolute links are now made before
save/exists and half after. Every existing assertion and every link stays; no product code changes.How it was tested
Arch Linux, GCC 16.2.1 and Clang 23.1.3. The new test against the product source from before #2832 (
76101111) and against main (3723fd0b), 30 runs a cell, passes/failures:saveand 18 after it. With fix(saves): a link to an entry that moved first follows it to the new place #2832's own test the old code failed only on btrfs; now it fails on both.tests/test_linux_saves_move.pypasses on Ubuntu and is skipped cleanly on Windows as before; the run is red only in two tests that are red on main itself today (test_readme_menu_rows.py, fixed by docs(readme): the option table has the Skip opening row, so main's readme check passes #2857;test_wb_shadow_remake.pyon Windows, fixed by fix(tests): the write-back shadow remake check builds on Windows #2868).test_readme_menu_rows.py(main's, as above) and the updater digest check (a .NET reference pack this PC lacks).Not measured: ext4/xfs or other real filesystem orders; Windows, where this check skips; a real game's first-start migration or real saves.
Refs #2832.
Assisted-by: GPT-6 Astra
Co-Authored-By: GPT-6 Astra noreply@openai.com