Repository navigation
fix(tests): main's readme and Windows write-back checks pass again - #2883
Merged
Merged
Conversation
Two checks fail on main, so every pull request merged with it is red: - tests/test_readme_menu_rows.py (Linux and Windows): the Gameplay tab's Skip opening row (NotRexed#2827) has no line in readme.md's option table, which NotRexed#2105 made list every menu row. Adds the line in the menu's order, after Discord status: Off / On, default Off. - tests/test_wb_shadow_remake.py (Windows only): its fixture reads the environment through getenv, which MSVC's headers mark deprecated, an error under -Werror. Adds -D_CRT_SECURE_NO_WARNINGS as the other fixtures do. The same two changes as NotRexed#2857 and NotRexed#2868, together, so one merge makes main green (each of those alone still fails the other's check). Assisted-by: Claude Code (claude-opus-5-5) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
klimovich008
added a commit
to klimovich008/Hookshot
that referenced
this pull request
Nov 12, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every pull request is red right now because two checks fail on main itself, not because of anything in the PRs. This fixes both in one merge so main's CI goes green again.
What fails
tests/test_readme_menu_rows.py(Linux and Windows): the Gameplay tab's Skip opening row (feat(menu): let Gameplay skip the new-game opening #2827) has no line inreadme.md's option table, which docs(readme): the option table lists every row of the menu #2105 made list every row of the menu. Adds the line in the menu's order (after Discord status, before Bug report): Off / On, default Off.tests/test_wb_shadow_remake.py(Windows only): the fixture reads the environment throughgetenv, which MSVC's headers mark deprecated, so the build stops under-Werror:-D_CRT_SECURE_NO_WARNINGS, as the other fixtures already do.(
tests/test_program_cache_one_variant.py, the third failure in the same runs, is already fixed on main by #2861.)Relation to #2857 and #2868
These are the same two changes as @nullifyshot's #2857 and @mooki000's #2868, combined. Each of those alone still fails the other's check, so neither can show green CI by itself. Merge this, or merge both of those; either way main ends up the same. Whichever goes second has nothing left to do.
Tested
On Windows 11 with LLVM clang++, on main 4cf785a:
test_readme_menu_rowsFAILED (Skip openingmissing),test_wb_shadow_remakefailed to compile with the threegetenverrors above;python -I -B tests/run_all.py readme wb_shadow_remake one_variant: 3 passed, 0 failed.Failing checks were taken from the run summaries of eight recent PRs' "Game-free source regressions" runs (every one had a subset of these three). Tests and docs only; nothing in the game changes, so no game run.
🤖 Generated with Claude Code