Repository navigation
refactor(pi): type action ids with Pi's branded id types - #343
Merged
Merged
Conversation
This was referenced Oct 8, 2026
eersnington
force-pushed
the
chore/pi-branded-ids
branch
from
October 8, 2026 15:40
217f68a to
58e87d5
Compare
eersnington
added this pull request to stack #347
October 8, 2026 16:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pi's ids are numbers with a compile-time brand (
Id<"conversation">,Id<"submission">, ...). Our actions already returned branded ids, but tooknumberand cast it back 13 times. A client could pass aSubmissionIdwhere aConversationIdbelongs and still compile.ConversationId,SubmissionId,TaskId, orEntryId, and every id cast is gone, also inrequireConversation,requireSubmission, andrequireTask.PiPromptOptions.conversationId, the storedWatchSpec, and thepi.events,pi.view, andpi.docframes carry aConversationId.ROOT_CONVERSATION_IDor an id from a response.This is part 6 of 9 in a stack: