Repository navigation
fix(pi): read an app credential with one source call - #338
Merged
Merged
Conversation
|
This PR was not deployed automatically as @eersnington does not have access to the Railway project. In order to get automatic PR deploys, please add @eersnington to your workspace on Railway. |
This was referenced Oct 8, 2026
eersnington
added this pull request to stack #347
October 8, 2026 16:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each model call read the app's credential with two calls to the app's source:
list(), thenread(). 0.5.1 removed the credential cache, so both calls ran on every model call.async read(providerId: string): Promise<PiCredential | undefined> { - if (!(await this.list()).some((entry) => entry.providerId === providerId)) - return undefined; return toPiCredential(await this.#source.read(providerId)); }PiCredentialSourcecontract already saysreadreturnsundefinedfor a provider without a credential, so thelist()check added nothing.{ signal }stays in the store. The documented source is a credentials Actor handle (client.credentials.getOrCreate([...])), and its actions would receive the signal as an extra argument.This is part 1 of 9 in a stack: