Repository navigation
fix(sandbox-adapter): stop Pi env calls when the run aborts - #339
Merged
Merged
Conversation
This was referenced Oct 8, 2026
eersnington
force-pushed
the
fix/pi-env-abort
branch
from
October 8, 2026 15:40
9498e80 to
b01a349
Compare
eersnington
added this pull request to stack #347
October 8, 2026 16:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pi passes the run's
Contextto every env call, andcontext.abortSignalfires when the run stops (an abort action, a destroy, or the end of the sleep grace period). Onlyexecread it. A Stop during a sandbox cold start still wrote the file once the sandbox came up, and Pi's abort waited for it.sequenceDiagram participant Client participant Pi as Pi Durable participant Env as sandboxEnv participant Sandbox Pi->>Env: writeFile("hello.txt", context) Env->>Sandbox: connect() (cold start) Client->>Pi: conversation.abort() Pi-->>Env: context.abortSignal fires Sandbox-->>Env: connected Note over Env: before: writes hello.txt<br/>after: returns FileError("aborted")Sandbox env (
sandbox-env.ts):aborted, asexecalready did.Database env (
database-env.ts):scanLineschecks it before each 64 KiB chunk, so a scan of a large file stops early.This is part 2 of 9 in a stack: