Repository navigation
Fix: the doctor and tests treat usbOnly packages as having no card form - #1387
Merged
Merged
Conversation
The doctor decided card form from a package's C sources alone, while the card build and the native comparison test use moduleCardless, which also counts usbOnly. A usbOnly module was asked for card packages and a native comparison it cannot have. Use the shared rule. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Both encoded the old rule that only requires or C sources make a package USB-only. Use the rule the card build and moduleCardless already use. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 10, 2026
3 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm run module:doctordecided whether an Octatrack module has a card form from its USB package's Csourcesonly. The card build, the source importer and the native comparison test usemoduleCardlessinsrc/catalog/usb-only.ts, which also countsusbOnly: true. So a module markedusbOnly, asdocs/OCTATRACK_RECONSTRUCTION.mddescribes, was asked for card packages, a native comparison and card pairs that it can never have, and the doctor test (--all) failed on it. Two tests encoded the same old rule:src/catalog/usb-only.test.tsexpected every package withoutrequiresorsourcesto have a card form, andscripts/module-release-scope.test.mjsbuilt its USB-only set fromsourcesonly, so ausbOnlymodule looked like an unreviewed card module and the scope check refused it.scripts/build-module-packages.pyalready usessources or usbOnly. No module on main usesusbOnlyyet. Track Solo (Track Solo 0.2.4-experimental: hold a track to solo it while editing #1383) is the first, after the owner asked for it there.moduleCardlessand uses it, so there is one rule for card form. AusbOnlymodule now gets the same lines as a C runtime module: its USB package version is checked, and the native comparison and card pair lines become informational. The packages line says which kind it is. Both tests now use the same rule asbuild-module-packages.pyandmoduleCardless. Changelog:changelog/2026-11-10-doctor-usb-only.md.usbOnlyin a scratch worktree. Main's doctor still said "compiled into the committed packages" and checked its native comparison; with this change it says "USB package … (a USB-only module, no card form)" and skips the card-only lines. Tiempos (C sources) and Tuner (card only) report exactly as before. On the Track Solo branch (Track Solo 0.2.4-experimental: hold a track to solo it while editing #1383), the firstusbOnlymodule,usb-only.test.tsandmodule-release-scope.test.mjsfail without this change and pass with it (8 tests). On main,npx vitest run scripts/module-doctor.test.mjs scripts/module-release-scope.test.mjs src/catalog/usb-only.test.tspasses (12 tests).npm run pr:ready: every stage passes exceptsdk:check, where only the two composition tests fail, becausem68k-elf-gccis not installed on my Mac; CI has it.docs/OCTATRACK_RECONSTRUCTION.mdalready describesusbOnlycorrectly; the doctor had not caught up with it.🤖 Generated with Claude Code