Skip to content

Fix: count usbOnly packages as having no card form in two tests - #1388

Merged
repeat98 merged 4 commits into
repeat98:mainfrom
twwwy:fix/release-scope-test-usb-only
Nov 11, 2026
Merged

repeat98 merged 4 commits into
repeat98:mainfrom
twwwy:fix/release-scope-test-usb-only

Conversation

@twwwy

@twwwy twwwy commented Nov 10, 2026

Copy link
Copy Markdown
Contributor
  • What was wrong or hard: Two tests work out for themselves which Octatrack modules have no card form, and both count only C sources (and requires). The build (cardless_modules in scripts/build-module-packages.py) and the site (moduleUsbOnly/moduleCardless in src/catalog/usb-only.ts) also count a USB package marked usbOnly: true, as docs/OCTATRACK_RECONSTRUCTION.md describes. No module on main is marked usbOnly yet, so nothing failed. The first one fails both tests although the build and the site handle it correctly: module-release-scope.test.mjs hands the card-scope check a module the build would never pass it ("Unsupported reviewed module scope"), and usb-only.test.ts expects moduleUsbOnly to be false for it. Pattern Sample Locks 0.1.8, whose first release is ready on a branch, is that module.
  • What this changes: module-release-scope.test.mjs takes the card scope from the builder's own cardless_modules, with a new case showing that a usbOnly package is left out and a usbOnly: false one is kept. usb-only.test.ts counts usbOnly in its expectation for every published package. No code under test changes. Changelog: changelog/2026-11-10-release-scope-test-usb-only.md.
  • How I checked it: npm run pr:ready: Ready. Both test files pass on main (9 tests). On the Pattern Sample Locks release branch, which adds the first usbOnly package, both failed before this change and pass with it.
  • What the guides lacked or got wrong, and where I fixed it: nothing. The reconstruction guide already says usbOnly uses the same card refusal path as C source runtimes; only these two tests had not caught up.

Separately, #1387 brings the module doctor to the same rule.


🤖 Generated with Claude Code

twwwy and others added 2 commits November 10, 2026 18:24
The test rebuilt the USB-only set from C sources alone, so the first module
marked usbOnly failed it although the build leaves it out of the card scope.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added the bug Something isn't working label Nov 10, 2026
@repeat98

Copy link
Copy Markdown
Owner

Thanks, this is the better form of that test: it asks the builder's own cardless_modules instead of copying its rule. #1387 changed the same line and went in first, since Track Solo needs its doctor change. Please merge main into this branch and keep your version of that line and your new case; usb-only.test.ts is already the same on both. Once pr:ready says Ready and the checks are green, I'll merge it.

@repeat98
repeat98 merged commit 0a0d3be into repeat98:main Nov 11, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants