Repository navigation
Fix: count usbOnly packages as having no card form in two tests - #1388
Merged
Merged
Conversation
The test rebuilt the USB-only set from C sources alone, so the first module marked usbOnly failed it although the build leaves it out of the card scope. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
Thanks, this is the better form of that test: it asks the builder's own |
…est-usb-only # Conflicts: # scripts/module-release-scope.test.mjs
3 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sources(andrequires). The build (cardless_modulesinscripts/build-module-packages.py) and the site (moduleUsbOnly/moduleCardlessinsrc/catalog/usb-only.ts) also count a USB package markedusbOnly: true, asdocs/OCTATRACK_RECONSTRUCTION.mddescribes. No module onmainis markedusbOnlyyet, so nothing failed. The first one fails both tests although the build and the site handle it correctly:module-release-scope.test.mjshands the card-scope check a module the build would never pass it ("Unsupported reviewed module scope"), andusb-only.test.tsexpectsmoduleUsbOnlyto be false for it. Pattern Sample Locks 0.1.8, whose first release is ready on a branch, is that module.module-release-scope.test.mjstakes the card scope from the builder's owncardless_modules, with a new case showing that ausbOnlypackage is left out and ausbOnly: falseone is kept.usb-only.test.tscountsusbOnlyin its expectation for every published package. No code under test changes. Changelog:changelog/2026-11-10-release-scope-test-usb-only.md.npm run pr:ready: Ready. Both test files pass onmain(9 tests). On the Pattern Sample Locks release branch, which adds the firstusbOnlypackage, both failed before this change and pass with it.usbOnlyuses the same card refusal path as C source runtimes; only these two tests had not caught up.Separately, #1387 brings the module doctor to the same rule.
🤖 Generated with Claude Code