Repository navigation
Pattern Sample Locks 0.1.8-experimental: first release, USB only - #1423
Merged
repeat98 merged 3 commits intoNov 11, 2026
Merged
Conversation
Moves the module out of sdk/drafts as the exact package tested on the MKII (3e13c46f), adds its catalogue entry, USB package, qualification record and release notes, and points the helper scripts at the new folder depth. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e-locks-0.1.8-release # Conflicts: # sdk/catalog.json # src/catalog/module-documents.json # src/engine/assets/octatrack-module-packages.json # src/engine/elekloader/module-set.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Module first release: Pattern Sample Locks 0.1.8-experimental (Octatrack MKII, USB only). Owner review requested for the first release.
What changes for players: FUNC + PART opens Sample Locks. Lock writes each chosen Flex/Static track's Part sample into the pattern's sample trigs as SAMPLE locks, and keeps every existing SAMPLE lock unless Replace existing is on. Clear removes all SAMPLE locks on the chosen tracks, manual ones included, and leaves every other lock alone. The page shows per-track counts and YES applies. Playback keeps running, and nothing is saved until the project is saved.
Version and scope:
0.1.8-experimental. The folder moves fromsdk/drafts/pattern-sample-lockstosdk/octabam/modules/pattern-sample-locks, with a catalogue row and a USB package (octabam,reconstruction,usbOnly). It needs the Modwerk base over USB, so there is no card form. Release notes are insrc/community/module-changelogs/pattern-sample-locks.json.Compatibility: it claims
screen:PART EDITand has no MIDI path and no stock site shared with another module. It is listed in the USB module set (module-set.test.ts), and the compatibility pairs are regenerated. Known limitations are in the manifest: the unexplained SAMPLE change in one high-load development run, and one long-session case where the menu rows didn't appear until a power cycle.Evidence:
public/octatrack-modules/pattern-sample-locks/0.1.8-experimental.mwrm, sha2563e13c46fb0054d05f228b045746453e0c50dbbe52fb53b3c229d598ddd7fed79, 10,048 bytes. It is byte-identical to the package tested on the unit.800a3ac6a6ac8c523ffa9d19232fc358372bed8697e0b71bbdf77418d62abdcdand image3e13c46f…. The runtime sources are unchanged since5a15ac39. The move only corrected the helper scripts' paths to the repository root, and no input pinned by the reconstruction recipe changed.Attribution: original MIT source by twwwy. The small lettering is reused from twwwy's Beat Slicer under MIT. No stock firmware or extracted tables are included.
What the guides lacked or got wrong: nothing for this module. Along the way, the doctor and two tests didn't recognise
usbOnlypackages. #1387 and #1388 fixed that as separateFix:PRs, and both are merged.docs/module-guides/, and TESTING.md lists what I did not test. An effect module holds one effect.First release, so both automatic-publication boxes stay unticked:
Reviewer:
Validation commands and results:
npm run pr:ready: Ready on the branch after merging currentmain.python3 -B scripts/octatrack-module-packages.py --check --stock <OS 1.40C>, with the m68k toolchain anddsp_asm: every Octatrack package identical, Sample Locks3e13c46fincluded. Its longest run shared with the stock OS is 11 non-zero bytes, under the limit of 12.npm run module:doctor -- pattern-sample-locks: green.Note: with
dsp_asmpresent,sdk/tests/test_resident_engines.pyfails on a cleanmaintoo (the Analog BD engine is 1,004 words, but the test expects 1,009). CI skips that test, and this PR doesn't touch it. I've raised it with the owner on the agent board.Related to #1088, #1313.
🤖 Generated with Claude Code