Skip to content

perf(ci): FLOW-010 cut 1 — drop aprender-compute dev-dep on aprender-core (Refs #5803) - #6179

Closed
noahgift wants to merge 1 commit into
mainfrom
fix/5803-tuner-move-sq2
Closed

noahgift wants to merge 1 commit into
mainfrom
fix/5803-tuner-move-sq2

Conversation

@noahgift

Copy link
Copy Markdown
Member

Rebuild of #6148, #6166 and #6168 (#6168 never got a quorum: PMAT-5803 was not in the roadmap, so pmat work status found nothing; this PR carries the entry, taken from #6138) (DIRTY after main moved; guards-nightly step + manifest row now sit beside the affected-set ones), linear off current main. Supersedes #6127 and #6148: same single move commit with the seat-2 findings folded in, still one commit and one ticket.

  1. ml-tuner documented as a deprecated no-op (Cargo.toml still declares ml-tuner = []).
  2. check_tuner_test_move.sh reads CI fragments 295 and 298 (mutants S16, S17 turn it red); the false L6 label is gone.
  3. The unproven "proved in the PR body" claim is replaced by what is true: compared at move time, digests pin the bodies now.
  4. grep rc>=2 fails closed (mutant S18 isolates it: red with the guard, green without).

--self-test: 26 passed, 0 failed; live check green.

🤖 Generated with Claude Code

…core (Refs #5803)

Moves the tuner tests so aprender-compute no longer dev-depends on aprender-core. Carries the PMAT-5803 roadmap entry (pmat work status could not find it, so the quorum never ran); the guards-nightly step and manifest row sit beside the affected-set ones.

PMAT-Ticket: PMAT-5803
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

§13.11 rung 1 — quorum shadow verdict

S13-SHADOW pr=6179 head=8334d55f050184b9822c30b918932347187dca7c verdict=REFUSE class=Q1 arm_rc=1

Shadow mode: this records a verdict and merges nothing. A refusal
to arm is not a block (§13 adds zero rows to §7) — the pull request is
exactly as green as it was.

@noahgift noahgift left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SEAT 1 non-author (w5018, claude-sonnet-5-5) at head 8334d55: PASS. Delta vs the reviewed #6168 is only the PMAT-5803 roadmap entry (fragment + aggregate, same content, well-formed); pr-light green at this head.
patch-id 76dd3d9a972155e00800457ec1bd8fa7fc0149a5 8334d55

@noahgift

Copy link
Copy Markdown
Member Author

quorum-review (AD-04): three PASS — agreed (auto_merge: checked=true was_armed=false disarmed=false)

{
 "ticket": "PMAT-5803",
 "head": "8334d55f050184b9822c30b918932347187dca7c",
 "width": 3,
 "executor": "agy",
 "agreed": true,
 "auto_merge": {
  "checked": true,
  "was_armed": false,
  "disarmed": false,
  "note": "auto-merge not armed"
 },
 "lanes": [
  {
   "lane": 1,
   "verdict": "PASS",
   "findings": 5
  },
  {
   "lane": 2,
   "verdict": "PASS",
   "findings": 6
  },
  {
   "lane": 3,
   "verdict": "PASS",
   "findings": 0
  }
 ]
}

@noahgift

Copy link
Copy Markdown
Member Author

SEAT (non-author, aprender-w5382 [f918a9]) on #6179 @8334d55f05, 2026-10-23 ~16:1xZ.

  • Ran scripts/check_tuner_test_move.sh --self-test at this head: 26 passed, 0 failed (S16/S17/S18 mutant rows red as claimed).
  • Read the guards-nightly.yml diff and the guard script; the guard is a nightly LAB lane with a LAB ticket step, no PR-path job added. CI fragments 295/298 only add one line each.
  • "C303": the comment # #4709 (C303): the pv census ratchet is NOT added by this PR; it is on main (guards-nightly.yml:397). The PR touches that line only to replace the (C324) citation with (nightly-only lane rule). The PR adds no new C-number. Existing C303 text is a pre-existing leftover, not this PR's.
  • Privacy: no flow-manifest / tier text / revenue-path in the diff (grepped added lines). No privacy check is red at this head.
  • NOT resolved: gate is FAILURE at 15:37Z (run 39977743455: workspace-test and mg-reuse-self-test failed; no failing step recorded, I did not diagnose). pr-light is SUCCESS. Seat is on the diff content; the red gate needs a rerun/diagnosis before arming.
  • Not reviewed line by line: the ~170-line test move into crates/aprender-compute/tests and the book/doc edits.

Verdict: PASS on content, with the red gate flagged.

@noahgift

Copy link
Copy Markdown
Member Author

quorum-review (AD-04): three PASS — agreed (auto_merge: checked=true was_armed=false disarmed=false)

{
 "ticket": "PMAT-1955",
 "head": "8334d55f050184b9822c30b918932347187dca7c",
 "width": 3,
 "executor": "agy",
 "agreed": true,
 "auto_merge": {
  "checked": true,
  "was_armed": false,
  "disarmed": false,
  "note": "auto-merge not armed"
 },
 "lanes": [
  {
   "lane": 1,
   "verdict": "PASS",
   "findings": 4
  },
  {
   "lane": 2,
   "verdict": "PASS",
   "findings": 0
  },
  {
   "lane": 3,
   "verdict": "PASS",
   "findings": 0
  }
 ]
}

noahgift pushed a commit that referenced this pull request Oct 24, 2026
PMAT-Ticket: PMAT-5803
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@noahgift
noahgift marked this pull request as draft October 25, 2026 09:21
@noahgift noahgift added the parked Closed over epic budget (APR-EPIC-001 rule 5). Reopen = pull. label Oct 25, 2026
@noahgift

Copy link
Copy Markdown
Member Author

Parked by R4 triage (conflicting). Ticket: PMAT-5803. The ticket stays open and links this PR; reopen or re-cut when rebased. Head 8334d55.

@noahgift

Copy link
Copy Markdown
Member Author

Corrected ticket line. Ticket: #5803. It is open and links this PR; any earlier "Ticket:" line on this PR is superseded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parked Closed over epic budget (APR-EPIC-001 rule 5). Reopen = pull.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant