Skip to content

perf(ci): FLOW-010 cut 1 — drop aprender-compute dev-dep on aprender-core (Refs #5803) - #6168

Closed
noahgift wants to merge 1 commit into
mainfrom
fix/5803-tuner-move-sq1
Closed

noahgift wants to merge 1 commit into
mainfrom
fix/5803-tuner-move-sq1

Conversation

@noahgift

Copy link
Copy Markdown
Member

Rebuild of #6148 and #6166 (DIRTY after main moved; guards-nightly step + manifest row now sit beside the affected-set ones), linear off current main. Supersedes #6127 and #6148: same single move commit with the seat-2 findings folded in, still one commit and one ticket.

  1. ml-tuner documented as a deprecated no-op (Cargo.toml still declares ml-tuner = []).
  2. check_tuner_test_move.sh reads CI fragments 295 and 298 (mutants S16, S17 turn it red); the false L6 label is gone.
  3. The unproven "proved in the PR body" claim is replaced by what is true: compared at move time, digests pin the bodies now.
  4. grep rc>=2 fails closed (mutant S18 isolates it: red with the guard, green without).

--self-test: 26 passed, 0 failed; live check green.

🤖 Generated with Claude Code

…core (Refs #5803)

Moves the tuner tests so aprender-compute no longer dev-depends on aprender-core. Rebuilt linear off main as one commit; the guards-nightly step and manifest row sit beside the affected-set ones.

PMAT-Ticket: PMAT-5803
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

§13.11 rung 1 — quorum shadow verdict

S13-SHADOW pr=6168 head=1be39a0494f4138924b343a438825cae256aab8a verdict=REFUSE class=Q1 arm_rc=1

Shadow mode: this records a verdict and merges nothing. A refusal
to arm is not a block (§13 adds zero rows to §7) — the pull request is
exactly as green as it was.

@noahgift noahgift left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seat 2 (non-author, aprender-w5018, claude-sonnet-5-5) at head 1be39a0. Verdict: APPROVE content.

  • Moved tests are not lost: the old training_data_quality.rs fns (compared by name) = 8 now in aprender-core/tests/tuner_training_data_quality.rs + 4 kept in aprender-compute; the 4 dropped (f041_f044/f046/f047/f048 *_ml_tuner_disabled) were empty '// Pass' stubs under cfg(not(feature=ml-tuner)), which is now a no-op feature.
  • aprender-compute loses the aprender-core dev-dep (Cargo.lock -1); aprender-core already depends on trueno, so the dependency edge now points one way. ml-tuner stays as an empty feature (no semver break).
  • Both test targets are wired: ci/explicit-test-commands.d 295 and 298. The listing guard is LAB, nightly-only (guards-nightly.yml, its own ticket step), so nothing new on the PR path.
  • Rest is comment/doc/README/book rewording.
    Not run: tests (CI per cop).

patch-id b19605cdbe4530bb69cce437f89a8526f6a37cf1 1be39a0

@noahgift

Copy link
Copy Markdown
Member Author

superseded by #6179 (carries the PMAT-5803 roadmap entry so quorum can read the ticket)

@noahgift noahgift closed this Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant