Repository navigation
Conversation
…core (Refs #5803) Moves the tuner tests so aprender-compute no longer dev-depends on aprender-core. Rebuilt linear off main as one commit; the guards-nightly step and manifest row sit beside the affected-set ones. PMAT-Ticket: PMAT-5803 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
§13.11 rung 1 — quorum shadow verdict Shadow mode: this records a verdict and merges nothing. A refusal |
noahgift
commented
Oct 23, 2026
noahgift
left a comment
Member
Author
There was a problem hiding this comment.
Seat 2 (non-author, aprender-w5018, claude-sonnet-5-5) at head 1be39a0. Verdict: APPROVE content.
- Moved tests are not lost: the old training_data_quality.rs fns (compared by name) = 8 now in aprender-core/tests/tuner_training_data_quality.rs + 4 kept in aprender-compute; the 4 dropped (f041_f044/f046/f047/f048 *_ml_tuner_disabled) were empty '// Pass' stubs under cfg(not(feature=ml-tuner)), which is now a no-op feature.
- aprender-compute loses the aprender-core dev-dep (Cargo.lock -1); aprender-core already depends on trueno, so the dependency edge now points one way. ml-tuner stays as an empty feature (no semver break).
- Both test targets are wired: ci/explicit-test-commands.d 295 and 298. The listing guard is LAB, nightly-only (guards-nightly.yml, its own ticket step), so nothing new on the PR path.
- Rest is comment/doc/README/book rewording.
Not run: tests (CI per cop).
patch-id b19605cdbe4530bb69cce437f89a8526f6a37cf1 1be39a0
Member
Author
|
superseded by #6179 (carries the PMAT-5803 roadmap entry so quorum can read the ticket) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebuild of #6148 and #6166 (DIRTY after main moved; guards-nightly step + manifest row now sit beside the affected-set ones), linear off current main. Supersedes #6127 and #6148: same single move commit with the seat-2 findings folded in, still one commit and one ticket.
ml-tuner = []).--self-test: 26 passed, 0 failed; live check green.
🤖 Generated with Claude Code