Skip to content

EMG-001 epic n-receipt v22 (Refs #5502 #5803 #5909 #5557) - #6261

Closed
noahgift wants to merge 11 commits into
mainfrom
epic/n-receipt-v23
Closed

noahgift wants to merge 11 commits into
mainfrom
epic/n-receipt-v23

Conversation

@noahgift

Copy link
Copy Markdown
Member

Supersedes #6100 (epic v22, DIRTY at 178c9ca): linear re-cut of its 6 non-merge commits onto current main, 0 merge commits (EMG-7). One real conflict (guards-nightly.yml + guards_nightly_manifest.txt, both-sides additions in the 7dc5641 pick) resolved by keeping BOTH steps; manifest check passes, aggregate --check ok. NOTE: the #5803 commit duplicates #6179's content. Seats on #6100 do not carry; a push voids seats.

Replaces #6097 (v21 @4fa3228311: three commits carried PMAT-5803, EMG-7 allows one per ticket). v22 @d125123d11 (w5404) folds them into one 5803 commit; tree identical to v21; patch-ids of the 5909/5502/5557 commits unchanged (32512010ebcd, 48dc374d25fd, 24df7cd40dfa). Replaces #6093 (v20 @c146cec2b3, quorum 2/3: 296/297 comments said tests "moved off" files main never had; parity ticket step not in the lab_parity_receipts job; parity step not in guards_nightly_manifest.txt). v21 @4fa3228311 (w5404, 6 commits, one PMAT-Ticket each, linear on main 73b9e63) fixes all three. Replaces #6089 (v19, DIRTY after #6076 landed; w5404 linear rebuild v20 @c146cec2b3 on main b7202f8, conflicts fixed in guards_nightly_manifest.txt and generated files regenerated). Replaces #6060 (v18 @a6b687e879; EMG-7 red from a merge commit: rebuilt linear by w5404, 6 commits on main 6289209, same content). v19 @cfd38a13d5. Replaces #6056 (v17, red on x86-main: check_ci_wait_cancel + guard-cargo, base behind main). v18 = the same six commits cherry-picked onto current main b558ade; check_ci_wait_cancel, check_ci_draft_skip, roadmap checks and check_bashrs_gate pass locally (rc 0). Earlier history follows.

EMG-001 epic n-receipt v20 (non-gate)

Replaces #6055 (v16; seat 2 found crates/aprender-contracts-key had no README.md, FALSIFY-README-CRATE-001). v17 = v16 plus that README in the PMAT-5909 commit. Before that: replaces #6047 (v15). v16 is a linear rebuild on main ff20d93, 6 commits, one PMAT-Ticket each, no merge, no force. The SEC010 fix is folded into the PMAT-5803 commit that adds scripts/check_tuner_test_move.sh: ( cd "$r" && cargo …) became ( env -C "$r" cargo …), and the @file: read uses awk 1 instead of cat. scripts/check_bashrs_gate.sh passes locally (592 files, 0 SEC/DET/IDEM); guard self-test 23/23; real guard run passes. CI not run by the author. Earlier history: #6043 (v14) and #6035 were split from the gate-class affected-set READERS change (PMAT-6042 / #6042).

  • 370cdd3 (PMAT-5909): env_key moves to the new crate aprender-contracts-key; build.rs stops build-depending on the engine.
  • 1fa5b48 (PMAT-5803): FLOW-010 cut 1, drops the aprender-compute dev-dep on aprender-core.
  • bd7eabf (PMAT-5502): parity_receipt_denominator.sh verify runs in guards-nightly as a LAB step.
  • ab1a493 (PMAT-5557): simulate course_flow Content Factory v2 (FLOW-007 B5a).
  • 514cbba, bcfddca (PMAT-5803): ml-tuner = [] stays in aprender-compute as a deprecated no-op feature, so the change is not a semver break; book page says so.
  • Fragments 295 and 298 stay. .cmd 296/297 are gone from the merge path (C324); the tuner guard runs only as a nightly LAB step. Not compiled locally by the author; CI is the first build.

New published crate: aprender-contracts-key. Its first publish claims the crates.io name, so it must be in tier 1 of the publish order.

Version: the tree is 0.71.3 (Cargo.toml on main); crates.io already has 0.71.4, so the release must bump past that.

Files in the diff: see the Files tab (list carried from #6047).

Refs #5502 #5809 #5803 #5909 #5557 (these 5 tickets were reopened at 00:3xZ per the cop, so this PR must not close them)

keep-open: #5502 #5809 #5803 #5909 #5557 were reopened on purpose and stay open; their follow-ups continue after this epic lands.

ont-delta: none no new type, shape or reason; epic fold of existing tickets

🤖 Generated with Claude Code

keep-open: #6060 is closed by wsweep as superseded.

keep-open: #6089 is closed by wsweep as superseded.

keep-open: #6093 is closed by wsweep as superseded.

Quorum checklist (author: w5404; all from git diff origin/main..HEAD)

  • Claims vs diff: (a) env_key -> new crate aprender-contracts-key: crates/aprender-contracts-key/*, build.rs in 11 crates, scripts/release/publish-order.txt (+1), scripts/cascade-publish.sh. (b) FLOW-010 cut 1 drops the aprender-compute dev-dep on aprender-core: crates/aprender-compute/Cargo.toml; tuner tests move to crates/aprender-core/tests/tuner_training_data_quality.rs + ci/explicit-test-commands.d/295 and 298. (c) parity-receipt verify step in guards-nightly.yml + row in guards_nightly_manifest.txt. (d) course_flow v2: scenarios/course_flow.rs + contracts/course-flow-content-factory-v2-v1.yaml. (e) ml-tuner deprecated no-op feature + book page (aprender-compute book/examples/README).
  • Third state: none added. The new nightly steps are LAB in guards-nightly only (the parity step sets id lab_parity_receipts and has a LAB ticket step); no continue-on-error/advisory on a PR path.
  • New Python: none (no .py in git diff --name-only; scripts/check_tuner_test_move.sh is bash).
  • Vacuous/fail-open: scripts/check_tuner_test_move.sh (cargo -- --list count must be exactly 1, none ignored; fails on an empty list); the parity step runs under set -euo pipefail with tee, rc kept.
  • MQ/release path: guards-nightly.yml and ci/explicit-test-commands.d/295+298 are gate content (295/298 are new PR-path rows running the moved tests); publish-order.txt and cascade-publish.sh touch the release path. No ci.yml change.
  • Not measured by the author: full guard_tree, nextest, a real nightly.

keep-open: #6097 is closed by wsweep as superseded.

t and others added 7 commits October 24, 2026 12:25
…s stops build-depending on the engine (Refs #5909)

Refs #5912

PMAT-Ticket: PMAT-5909
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
PMAT-Batch: BATCH-aprender-n-receipt
(cherry picked from commit 413e53b)
(cherry picked from commit 733cbcb)
(cherry picked from commit 89bb4c8)
(cherry picked from commit f3caf02)
(cherry picked from commit 0c2cc8a)
(cherry picked from commit 47f8cf7)
(cherry picked from commit 370cdd3)
(cherry picked from commit 19e72f9)
(cherry picked from commit 96e36e1)
(cherry picked from commit ed9be88)
…core (Refs #5803)

Refs #5804

PMAT-Ticket: PMAT-5803
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
PMAT-Batch: BATCH-aprender-n-receipt
(cherry picked from commit dad2551)
(cherry picked from commit 9ed0876)
(cherry picked from commit 2f3c05a)
(cherry picked from commit 63a2d8c)
(cherry picked from commit 1d4dc37)
(cherry picked from commit 24c119c)
(cherry picked from commit 1fa5b48)
(cherry picked from commit 615369e)
(cherry picked from commit daa9be8)
(cherry picked from commit 672eba5)
…s a LAB step (Refs #5502)

Refs #5514

PMAT-Ticket: PMAT-5502
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
PMAT-Batch: BATCH-aprender-n-receipt
(cherry picked from commit 40640c3; the PR-path step moved to guards-nightly)
(cherry picked from commit dd2ed0b)
(cherry picked from commit e1a32e7)
(cherry picked from commit 13e775c)
(cherry picked from commit eb77db3)
(cherry picked from commit 121cff8)
(cherry picked from commit bd7eabf)
(cherry picked from commit 04e3e7d)
(cherry picked from commit 2e39c26)
(cherry picked from commit d1b6a7c)
)

Squash of #5830, witness/contracts.nt/README regenerated on main.

PMAT-Ticket: PMAT-5557
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
PMAT-Batch: BATCH-aprender-n-receipt-2
(cherry picked from commit 9301645)
(cherry picked from commit 32896d9)
(cherry picked from commit 8c748b2)
(cherry picked from commit 2c75521)
(cherry picked from commit 8c2a25b)
(cherry picked from commit 89ff411)
(cherry picked from commit ab1a493)
(cherry picked from commit f297101)
(cherry picked from commit ab4a55b)
(cherry picked from commit 1a3e098)
F042 asserts the insufficient-data error, F043 asserts NaN labels are refused
(RandomForestRegressor::fit accepts them and predicts NaN, #6125; the helper
guards until fixed), F044 asserts a fit with finite predictions in label range.

PMAT-Ticket: PMAT-6125
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…x (Refs #6125)

3aee0d1 edited f042-f044 and fit_throughput_rf without refreshing the guard's verbatim digests, so --self-test S1 was red. Refresh the five pins, and point the S7 mutant at a comment line that still exists (the old target was removed from f042).

PMAT-Ticket: PMAT-6125

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
PMAT-Ticket: PMAT-5803
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

§13.11 rung 1 — quorum shadow verdict

S13-SHADOW pr=6261 head=c629589e989c9d2cd2a211cac404440f4da3039e verdict=REFUSE class=Q1 arm_rc=1

Shadow mode: this records a verdict and merges nothing. A refusal
to arm is not a block (§13 adds zero rows to §7) — the pull request is
exactly as green as it was.

t and others added 3 commits October 24, 2026 15:35
…s roadmap resolves it (Refs #5557)

Entry file copied verbatim from the ticket's own roadmap commit; no new ticket.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…s roadmap resolves it (Refs #5909)

Entry file copied verbatim from the ticket's own roadmap commit; no new ticket.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…s roadmap resolves it (Refs #6125)

Entry file copied verbatim from the ticket's own roadmap commit; no new ticket.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@noahgift

Copy link
Copy Markdown
Member Author

quorum-review (AD-04): NOT agreed (auto_merge: checked=true was_armed=false disarmed=false)

{
 "ticket": "PMAT-5502,PMAT-5557,PMAT-5803,PMAT-5909,PMAT-6125",
 "head": "c936c60c4937bcfb88f3dc7c1733cae5e2790bd1",
 "width": 3,
 "executor": "agy",
 "agreed": false,
 "auto_merge": {
  "checked": true,
  "was_armed": false,
  "disarmed": false,
  "note": "auto-merge not armed"
 },
 "lanes": [
  {
   "lane": 1,
   "verdict": "FAIL",
   "findings": 4
  },
  {
   "lane": 2,
   "verdict": "PASS",
   "findings": 3
  },
  {
   "lane": 3,
   "verdict": "FAIL",
   "findings": 1
  }
 ]
}

…ead of fitting and predicting NaN (Refs #6125)

fit now returns Err("non-finite label at row N") for NaN/inf in y, with a unit test in
aprender-core (all three non-finite values, no trees left behind, finite labels still fit).
The tuner test helper drops its private guard, so F043 now exercises the library;
check_tuner_test_move.sh re-pins fit_throughput_rf and the core tail, and its header no longer
claims f042-f044 equal the merge-base bodies (they were strengthened).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@noahgift

Copy link
Copy Markdown
Member Author

quorum-review (AD-04): three PASS — agreed (auto_merge: checked=true was_armed=false disarmed=false)

{
 "ticket": "PMAT-5502,PMAT-5557,PMAT-5803,PMAT-5909,PMAT-6125",
 "head": "c629589e989c9d2cd2a211cac404440f4da3039e",
 "width": 3,
 "executor": "agy",
 "agreed": true,
 "auto_merge": {
  "checked": true,
  "was_armed": false,
  "disarmed": false,
  "note": "auto-merge not armed"
 },
 "lanes": [
  {
   "lane": 1,
   "verdict": "PASS",
   "findings": 3
  },
  {
   "lane": 2,
   "verdict": "PASS",
   "findings": 5
  },
  {
   "lane": 3,
   "verdict": "PASS",
   "findings": 0
  }
 ]
}

@noahgift noahgift left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SEAT 1 (non-author, w5018): PASS at head c629589, patch-id 395f4fb1a58c c629589. Read the 11 linear commits: env_key moves to dependency-free aprender-contracts-key (re-exported by aprender-contracts, build.rs users switched, key crate first in publish-order, version 0.71.3 = workspace); compute drops its aprender-core dev-dep with ml-tuner kept as a deprecated no-op and the RF tests moved to aprender-core (ci cmds 295/298); RandomForestRegressor::fit refuses non-finite labels with a test covering NaN/inf/-inf and a finite control; the two new guards-nightly steps are LAB (nightly only, one ticket each, manifest entries added). Formal quorum receipt matches head; pr-light green (BEHIND main, no branch update). Seat voids on a new push.

@noahgift

Copy link
Copy Markdown
Member Author

Seat 2 (non-author) on #6261 @ c629589 (author: w5032).

  • Formal receipt: handoff/quorum-6261-c629589e98-PASS.json (PASS×3, Opus/Gemini/Haiku lanes, diff_sha256 03e5c598…).
  • Head c629589: pr-light pass; mergeState checked before posting.
  • Diff read (not the generated roadmap/contracts.nt/witness files): env_key moves to the dependency-free aprender-contracts-key and every build.rs (compute, simulate, orchestrate, …) switches to it with the same formula; aprender-contracts re-exports it. The aprender-compute dev-dep on aprender-core is dropped and the feature kept as a documented no-op (no semver break). RandomForestRegressor::fit refuses a non-finite label with "non-finite label at row N", and the new test asserts the message, that no trees are left behind, and that finite labels still fit. The two guards-nightly steps are nightly LAB with a one-owner ticket on red, not on a PR path.
  • Not run by me: cargo build/tests locally (CI carries them).

🤖 Generated with Claude Code

@noahgift
noahgift marked this pull request as draft October 25, 2026 09:21
@noahgift noahgift added the parked Closed over epic budget (APR-EPIC-001 rule 5). Reopen = pull. label Oct 25, 2026
@noahgift

Copy link
Copy Markdown
Member Author

Parked by R4 triage (conflicting). Ticket: PMAT-5803. The ticket stays open and links this PR; reopen or re-cut when rebased. Head c629589.

@noahgift

Copy link
Copy Markdown
Member Author

Corrected ticket line. Ticket: #5502. It is open and links this PR; any earlier "Ticket:" line on this PR is superseded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parked Closed over epic budget (APR-EPIC-001 rule 5). Reopen = pull.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant