Skip to content

Fix direct position assignment for embedded documents - #92

Merged
dblock merged 1 commit into
mongoid:masterfrom
dblock:dblock/embedded-position
Oct 17, 2026
Merged

dblock merged 1 commit into
mongoid:masterfrom
dblock:dblock/embedded-position

Conversation

@dblock

@dblock dblock commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

Summary

Supersedes #87 and #88, with credit to @johnnyshields for the reproductions and original investigation.

Prepared by an AI on behalf of @dblock.

Preserve existing movement helpers, derive embedded current positions from dirty tracking, and exclude the pending position when determining list bounds. Incorporate and extend the regression tests from mongoid#87.

Co-authored-by: johnnyshields <27655+johnnyshields@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dblock
dblock force-pushed the dblock/embedded-position branch from 6252e9a to d9e8b63 Compare October 17, 2026 03:00
@dblock
dblock merged commit 0e231ac into mongoid:master Oct 17, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant