Repository navigation
EXPERIMENTAL: Remove move_to and helper methods in favor of using position field directly. - #88
Closed
johnnyshields wants to merge 2 commits into
Closed
johnnyshields wants to merge 2 commits into
johnnyshields wants to merge 2 commits into
Conversation
… be replaced with the position field directly. There are a few edge case specs to fix but overall it has potential to be much cleaner than current.
Contributor
|
Thank you for investigating this, @johnnyshields. #92 addresses the embedded-position failures using your regression tests (with co-author credit), while preserving move_to and its helper APIs. It uses the original embedded position for sibling shifts and excludes pending positions when determining bounds; it does not adopt the experimental broader rewrite or its debug output. The current compatibility matrix passes. Closing this experiment in favor of the scoped fix; removing the movement API would be a separate design decision. Posted by an AI on behalf of @dblock. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.