Repository navigation
Failing specs for embedded doc position updating - #87
Closed
johnnyshields wants to merge 1 commit into
Closed
johnnyshields wants to merge 1 commit into
johnnyshields wants to merge 1 commit into
Conversation
dblock
added a commit
to dblock/mongoid_orderable
that referenced
this pull request
Oct 17, 2026
Preserve existing movement helpers, derive embedded current positions from dirty tracking, and exclude the pending position when determining list bounds. Incorporate and extend the regression tests from mongoid#87. Co-authored-by: johnnyshields <27655+johnnyshields@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Thank you for these reproductions, @johnnyshields. They exposed the embedded-position bug and are incorporated into #92, with co-author credit, alongside the fix and additional regression cases. #92 passes the current Ruby/Mongoid/MongoDB matrix. Closing this test-only PR in favor of that complete fix. Posted by an AI on behalf of @dblock. |
dblock
added a commit
to dblock/mongoid_orderable
that referenced
this pull request
Oct 17, 2026
Preserve existing movement helpers, derive embedded current positions from dirty tracking, and exclude the pending position when determining list bounds. Incorporate and extend the regression tests from mongoid#87. Co-authored-by: johnnyshields <27655+johnnyshields@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dblock
added a commit
that referenced
this pull request
Oct 17, 2026
Preserve existing movement helpers, derive embedded current positions from dirty tracking, and exclude the pending position when determining list bounds. Incorporate and extend the regression tests from #87. Co-authored-by: johnnyshields <27655+johnnyshields@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR currently demonstrates divergent behavior where the following are not equivalent on embedded docs:
This behavior does work correctly on non-embedded docs.
(TBD: perhaps we need an option to preserve legacy direct position setting behavior, but i doubt it...)