Repository navigation
feat(skills): ask where a decision already lives, in the plan, the review and the risk verdict - #154
Merged
Merged
Conversation
…view and the risk verdict A Plan and an Issue state a design block (Interface, Hides, Already lives). The default review answers four design questions and searches outside the diff. Land gains a Design check for copies and test seams. Coverage is reached through the interface, and a forced test seam is listed in the PR. To pay for it: the maintainability deep pass and the optional second reviewer for broad diffs go (the default pass now asks their questions), the rubric's What to Flag list goes (the checklist says what to look for), and the single-consumer pattern-audit module moves into forge-implement.
…and 6 of implement become one
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A copied module passes every forge step today, because each step judges one diff and the other copy is outside it. This makes the plan, the review and the risk verdict ask what already exists, who reads what is new, and what a replacement leaves behind.
Notes
pattern-audit.md(one consumer, now inline in forge-implement, whose steps 5 and 6 are one step).docs/testing.mdsays so, and no sandbox PR isolates the Exercise check any more.skills/go up by about 1 %.Change outline
One rule restated per place:
deep-modules.mddesign block: Already livesreview-dimensions.mditem 3, question 1; a copy is P1risk-rubric.mdDesign: copiesphase-execution.md2. Test; forge-implement step 6Exercised
Snapshots:
forge-newat 8fc4c8f (the first commit of this branch),forge-oldat 89ad722. The later commits (Leaves behind, the merged step, the removed checklist) were not exercised.Design: 1 test seam (countLines is exported from src/server.js and imported only by test/server.test.js)and a Where to look item asking whether the test can go through the route.Design: 1 test seam(countByTeam).forge-implement --unattendedon "add GET /notes/:id/tag-count": the Plan carriesDesign: no new module or variant on main. Interface: the route. Hides: the hashtag rule (one private countTags). Already lives: nowhere on main; sibling count routes exist only in open PRs #9, #48, #49. The helper stayed private. Sandbox PR feat(skills): sort CI failures, exercise the change, delegate the tracker #54, closed.scripts/check-skills.shprints nothing; Biomecipasses.claude plugin validateandclaude plugin testnot run.Try it: snapshot the branch as
docs/testing.mdsays and run/forge-new:forge-land 49read-only in the sandbox; expect aDesign:line.Plan
Plan as first made (no approver: the owner approved the proposal's items B1 to B5, B7 and B8 in another session, not this edit list)
deep-modules.md,review-dimensions.md,risk-rubric.md,phase-execution.md.deep-modules.md, used by forge-implement step 2, forge-create-issue and pre-flight.pattern-audit.md.Deviations (as of 41a66db):