Repository navigation
feat(survey): add forge-survey, a periodic design review with a stable record - #155
Merged
Merged
Conversation
…e record Findings carry a class, evidence, remedy and the rule or check that let them through, and live in docs/surveys/. A class that recurs across two surveys yields a guardrail instead of one more Issue per instance.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whole-codebase reviews keep finding the same classes of problem, and their reports are lost with the session that wrote them.
forge-surveyrecords each finding indocs/surveys/with its class, evidence, remedy and the rule or check that let it through, and turns a class that recurs into a guardrail.Notes
deep-modules.md(test seam, leftover of a replacement). The two PRs merge in either order; README is the only shared file.open.forge-survey, the eight classes, the record's homedocs/surveys/.Exercised
Snapshot
forge-newat 3fcbd19, run headless in a fresh clone of the sandbox. There is noforge-oldrun: the skill is new./forge-new:forge-survey: four fresh-context readers (three areas, one cross-module). It recorded six findings indocs/surveys/2026-11-10.md, each with class,file:lineevidence and aLet through bycell, for exampleQuality gate in AGENTS.md:9 ("syntax check"): missing. It listed three possible bugs separately, dropped three weak candidates, proposed no guardrail (first survey), and opened sandbox PR feat(ship): local-first shipping and a separate publish step #56 (closed).open.docs/survey-2026-11-10branch. Fixed in 73185cb (record from a temporary worktree); that fix was not re-run.scripts/check-skills.shprints nothing.claude plugin validateandclaude plugin testnot run.Try it: in any repository,
/forge-survey, then opendocs/surveys/<today>.md.Plan
Plan as first made (no approver: the owner asked for the skill, item B6 of the design guardrails proposal, and did not see this plan)
/forge-survey [paths], outputdocs/surveys/<date>.md. Hides: how areas are split and verified. Already lives: nowhere in forge;forge-reflectreviews a diff, and its review flow is not reused because a survey has no diff.docs/architecture.md, a Related Skills line in forge-setup-project, scenarios indocs/testing.md.Deviations (as of 73185cb): none