Repository navigation
feat(review): ask where else a fact is written and what holds the copies together - #158
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default review now asks where else a constant, bound, vocabulary or rule is written and what holds the copies together, so a fact restated in another tier or language is found at the diff, not after it lands.
Notes
Exercised
forge-new:forge-reflect(this branch) on a sandbox branch addingGET /notes/:id/previewplus a client that restates the 80-char length (with a "keep in sync" comment) and the id regex (without one) → P1 on the restated length, naming the id regex atsrc/server.js:17and the third copy indocs/api.md; plus 4 P2sforge-old:forge-reflect(base24f900e), same branch → P1 on the restated length only, no mention of the id regex; same 4 P2s, plus a tracker-spec P1 (the new run raised it as an open question) and one on the fixture's commit titleforge-ship --guardrun; the sandbox branch stayed local, no sandbox PR openedPlan
Plan as first made (no approver: run unattended, started by another session with --guard)
_shared/review-dimensions.mditem 3; it hides nothing new. The same decision already lives in the sibling question (feat(skills): ask where a decision already lives, in the plan, the review and the risk verdict #154) and the rubric's "a module or sequence copied from one that exists".scripts/sync-shared.shandscripts/check-skills.sh._shared/risk-rubric.md(feat(land): a gate loosened so the diff passes needs review, like a weakened test #157 edits it); no new module or variant.Deviations (as of c0b492e): none
Closes #156
Risk
Verdict: needs review, judged on c0b492e
Where to look (needs review only)
skills/_shared/review-dimensions.md:9: The Issue left two cuts to choose from. Is adding a fifth Design question (about 30 more words) better than folding this into the sibling question, as the PR'sJudgment callsNotes bullet argues?skills/_shared/review-dimensions.md:16: With "hardcoded values that should be constants" gone from item 5, will a review still flag an unexplained magic number that appears only once?skills/_shared/review-rubric.md:8: Should a restated fact with nothing holding the copies together be a P1 ("should fix before merge"), or does that over-block mirrors that are only kept in sync by a comment?