Repository navigation
Conversation
This was referenced Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching the native EQ's filter shape changes coefficients immediately while reusing its current state, producing a discontinuity. Preparation also clamps a newly requested cutoff using the previous sample rate before resetting the filter for the new rate.
This crossfades the old and new filter outputs over 10 ms with separate old coefficients/state. An ongoing transition finishes before the processor's repeated parameter updates accept the latest requested shape. Frequency/Q/gain smoothing uses a sample-rate-derived 10 ms interval rather than a fixed 500 samples. Preparation establishes the new rate before updating parameters and resets the settled state afterward. Coefficient dispatch uses a switch instead of replacing a std::function on shape changes.
Validation on Apple Silicon macOS, RelWithDebInfo:
d0226686, the first-sample discontinuity is approximately 0.096 / 0.088 / 0.023 respectively for a settled unity DC signal switching to high-pass.Independent native-EQ change based directly on main. This does not affect third-party plugin DSP. Linux/Windows validation is pending CI.
Combined validation: the four independent branches (#1211–#1214) merge without conflicts and all 62 CTest suites pass together on Apple Silicon macOS (4.06 s). Upstream Build/REUSE runs currently report
action_requiredpending maintainer approval for this fork; no cross-platform CI success is claimed.