Repository navigation
Conversation
Member
|
@claude - can you review this? |
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disabling a node can currently call
releaseResources()and reset its oversampler/RMS meters while an audio block is still using them. Off-message-thread enable requests also toggle the current state rather than applying the requested state; a quick off/on pair can therefore leave the node disabled. Off-thread oversampling can reconfigure the chain before the queued disable has executed.This adds an atomic render-admission lease around the complete node render operation, including oversampling, gain and meters. Unprepare closes admission and waits for existing users on the control/device lifecycle thread before releasing resources. A closed gate never makes the audio callback wait. Admission reopens only after prepare and meter allocation complete.
Enable and oversampling requests are marshalled to the message thread with their requested values. Internal temporary disable/re-enable during oversampling does not overwrite a newer externally requested enabled state. Root device stop/start still relies on the existing engine lifecycle synchronization; this is not a claim that arbitrary plugin state edits or graph edits are lock-free.
Validation on Apple Silicon macOS, RelWithDebInfo:
releaseResources()being called insideprocessBlock()on unmodifiedd0226686; the subsequent concurrent stress also triggers SIGTRAP there.Independent of the sample-unit correction in #1211. Linux/Windows validation is pending CI.
Combined validation: the four independent branches (#1211–#1214) merge without conflicts and all 62 CTest suites pass together on Apple Silicon macOS (4.06 s). Upstream Build/REUSE runs currently report
action_requiredpending maintainer approval for this fork; no cross-platform CI success is claimed.The concurrent lifecycle suite also passed 20 consecutive runs (4.63 s total).