Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An unrelated graph rebuild currently resets every latency-compensation delay line. Even adding an unconnected node can briefly drop a delayed signal to zero. Graph scratch storage is also resized/allocated while publishing a new rendering sequence, and changing device block lengths can resize graph output storage in the callback.
This preserves delay histories for matching source/destination node IDs, ports and delay length (not temporary scratch-buffer indices). History transfer and publication are protected by the existing render lock. New scratch audio/MIDI storage is allocated before acquiring publication locks, and old storage is destroyed afterward. Graph output capacity is prepared ahead of time and reused for smaller variable blocks; device input scratch and MIDI buffers are reserved during preparation.
The MIDI reserve is 64 KiB, not an allocation-free guarantee for arbitrary SysEx traffic or plugin output. Graph publication still uses locks, and history matching is O(new operations × old operations); this does not promise glitch-free arbitrary live graph editing.
Validation on Apple Silicon macOS, RelWithDebInfo:
GraphContinuityTestsmixes two constant sources with a 257-sample latency difference. On unmodifiedd0226686, adding an unconnected node drops all 128 samples in the next block from 0.75 to 0.5.Based directly on main and independent of #1211/#1212. Linux/Windows validation is pending CI.
Combined validation: the four independent branches (#1211–#1214) merge without conflicts and all 62 CTest suites pass together on Apple Silicon macOS (4.06 s). Upstream Build/REUSE runs currently report
action_requiredpending maintainer approval for this fork; no cross-platform CI success is claimed.