Repository navigation
Update kuttl to v0.28.0 and skip limit import tests with testRunSelector - #1037
Conversation
c39c94b to
e3efb18
Compare
mandre
left a comment
There was a problem hiding this comment.
I wonder if it's possible to make it a bit more dynamic and list boundaries rather than exact version it's supposed to run on (or not run on). This way, all of the testRunSelector can stay untouched on new openstack release, and we would just need to keep the e2e.sh file up to date, once per release cycle. Let me know what you think.
| - key: openstack-version | ||
| operator: NotIn | ||
| values: | ||
| - flamingo |
There was a problem hiding this comment.
I'd love to have something a bit more dynamic.
What do you think we introduce boundaries, such as we've done in gophercloud?
We could imagine something like:
testRunSelector:
matchLabels:
min-2026.1: "true"Which could be passed from the e2e.sh script with something like:
KNOWN_RELEASES=("2025.1" "2025.2" "2026.1")
labels=""
for release in "${KNOWN_RELEASES[@]}"; do
if [[ ! "$OS_RELEASE" < "$release" ]]; then
labels="${labels:+$labels,}min-${release}=true"
fi
if [[ ! "$OS_RELEASE" > "$release" ]]; then
labels="${labels:+$labels,}max-${release}=true"
fi
doneWhere we would only need to update KNOWN_RELEASES when a new test requires new boundaries not yet listed.
|
This overlaps with #208: I have a branch with kuttl v0.28 that adds a Since a testRunSelector:
matchExpressions:
- {key: admin, operator: NotIn, values: ["false"]}
- {key: min-2026.1, operator: In, values: ["true"]}and |
d68dc65 to
b735a59
Compare
b735a59 to
06c9b5d
Compare
Signed-off-by: Winston Chen <winchen@redhat.com>
06c9b5d to
c3f525a
Compare
This PR updates kuttl to v0.28.0 and skips limit import test cases with
testRunSelectorinTestCase.