You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Should allow skipping tests that require admin credentials #208
Some of the tests require admin credentials. We should find a way to skip these tests when running against clouds for which we don't have admin credentials.
I have this ready locally with kuttl v0.28: each test that uses openstack-admin gets a 00-test-case.yaml with a testRunSelector (admin NotIn ["false"]), so a run without labels runs everything, and E2E_KUTTL_SKIP_ADMIN=true passes --test-run-labels admin=false. Checked that it skips them. A unit test fails if a test uses openstack-admin without the file.
Two questions before I open it:
That's 143 new files, one per test, since kuttl can't select a whole directory. OK, or would you prefer something else?
For the 143 new files, this was expected as we need to add one to pretty much each of the tests.
Regarding your second question, about ordering in which this needs to merge, it's also expected that currently opened PR would conflict when we make a broad change like this affecting all controllers. My priority goes towards necessary broad changes like this one, then we'll adapt the open PRs to match.
Let's get your fix in once #1037 lands.
When making your change, don't forget to also update the scaffolding.
Activity
mandre commentedon Jan 31, 2025
Might be possible via the (undocumented) TestFile selector introduced in kudobuilder/kuttl#483.
mandre commentedon Jan 31, 2025
I'm trying to leverage the TestFile selector in a way that's not too awful but I'm getting nowhere.
mandre commentedon Oct 23, 2026
This should now be possible with kuttl v0.28.0
zunken1337 commentedon Oct 27, 2026
I have this ready locally with kuttl v0.28: each test that uses
openstack-admingets a00-test-case.yamlwith atestRunSelector(admin NotIn ["false"]), so a run without labels runs everything, andE2E_KUTTL_SKIP_ADMIN=truepasses--test-run-labels admin=false. Checked that it skips them. A unit test fails if a test usesopenstack-adminwithout the file.Two questions before I open it:
mandre commentedon Nov 3, 2026
@zunken1337 sorry I missed your comment.
For the 143 new files, this was expected as we need to add one to pretty much each of the tests.
Regarding your second question, about ordering in which this needs to merge, it's also expected that currently opened PR would conflict when we make a broad change like this affecting all controllers. My priority goes towards necessary broad changes like this one, then we'll adapt the open PRs to match.
Let's get your fix in once #1037 lands.
When making your change, don't forget to also update the scaffolding.