Repository navigation
e2e: allow skipping the tests that need admin credentials - #1059
Open
zunken1337 wants to merge 1 commit into
Open
zunken1337 wants to merge 1 commit into
zunken1337 wants to merge 1 commit into
Conversation
Tests using the openstack-admin cloud get a kuttl TestCase that skips them in test runs labelled admin=false (kuttl v0.28). E2E_KUTTL_SKIP_ADMIN=true sets that label. A unit test checks that every test using openstack-admin has the TestCase. Fixes k-orc#208 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #208
Tests which use the
openstack-admincloud get a00-test-case.yamlwhosetestRunSelectorexcludesadmin=false.E2E_KUTTL_SKIP_ADMIN=trueaddsadmin=falseto the test run labels from #1037, so a run without admin credentials skips them, and a run without labels still runs everything. The limit import tests select on both.test/kuttl/admin_test.gofailsmake testif a test usesopenstack-adminwithout the file. The scaffolding templates and the test docs mention it.Checked on a cloud without admin credentials: with
admin=falsethe admin tests are skipped and the others run.🤖 Generated with Claude Code