Repository navigation
Fix CI ccache SIGILL by keying on the resolved ISA - #269
Merged
Merged
Conversation
- Hash the flags `c++ -march=native` expands to, alongside the CPU model name, in the Linux ccache keys of all four workflows - Log the resolved ISA so a future failure shows which flags the runner had - Prefix the CUDA cache key so it no longer shares an entry with the Build workflow Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #269 +/- ##
=======================================
Coverage 96.92% 96.92%
=======================================
Files 194 194
Lines 17349 17349
Branches 943 943
=======================================
Hits 16816 16816
Misses 533 533
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Keys the Linux CI ccaches on the flags
-march=nativeexpands to, not only on the CPU model name, in four of the five workflows that use ccache (continuous,cuda,python,coverage).docsis handled in #270.c++ -march=native -E -v -'s resolved-m…flags together with the CPU model name, so the key is never weaker than before.ISA: …next toCPU: …, so a future failure shows what the runner exposed.cuda.ymlandcontinuous.ymlboth usedLinux-<config>-<cpu>-cache, so the CUDA and plain builds fought over one immutable entry. CUDA now usescuda-….Impact:
Why
Illegal instructionduringcatch_discover_testson EPYC 9V74 runners that restored a large Debug cache: Fix CMake options being forced in the cache #268 (CUDA (Debug)) and Extremum Sum Potential #259 (Linux (Debug)).Linux-Debug-1130b74ab145-cachekey: one frommain(507 MB), one fromrefs/pull/259/merge(452 MB).-march=native, not what it expands to. FindSIMD (SIMD_CXX_FLAGS) and Tight-Inclusion (its own target, no off switch) add it. Turning offIPC_TOOLKIT_WITH_SIMDwould drop the first but not the second.Type of change
How Has This Been Tested?
bash -n.g++-15on arm64 macOS. Its output on x86 gcc underubuntu-latestis untested locally. The CI on this PR exercises it, since each workflow triggers on its own file.Test Configuration:
Checklist