Repository navigation
Conversation
Member
Author
|
Superseded by #272, which includes these comment fixes along with the x86-64-v3 CI change. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #271 +/- ##
=======================================
Coverage 96.92% 96.93%
=======================================
Files 194 194
Lines 17348 17350 +2
Branches 944 944
=======================================
+ Hits 16815 16818 +3
+ Misses 533 532 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Corrects the CI comments added in #269 and #270 that name MeshFEMCore as a source of
-march=native.cmake/recipes/meshfem_sparse.cmakedownloads MeshFEMCore withDOWNLOAD_ONLYand compiles its own static library, so MeshFEMCore'sMESHFEM_NATIVEnever runs in our build.cuda.yml,continuous.yml,python.yml,coverage.yml, anddocs.ymlnow name the actual sources: FindSIMD (SIMD_CXX_FLAGS) and Tight-Inclusion's own target.Impact:
Type of change
How Has This Been Tested?
#comment lines, and all five workflows parse as YAML.Test Configuration:
Checklist