fix(docs): replace stale empty-board README screenshot - #6
Merged
Merged
Conversation
README/screenshots/main.png predated the reproducible Store screenshot
generator and showed a freshly-installed, empty board ("Allgemein", 0
entries) instead of the app's real functionality (T-20260926-413277423).
Repoint README (EN/DE/ES) and STORE_LISTING.md at the already-regenerated,
populated README/screenshots/store/main-window.png (Dev board, produced by
generate_store_screenshots.py) instead of maintaining a separate, easily
stale duplicate. Remove the stale main.png. Regenerated all four store
screenshots via `python generate_store_screenshots.py` to confirm they are
current and populated (no privacy-sensitive paths shown, only generic
program labels). LaunchBoards has no tracked README screenshot in this
repo, so there was nothing to check there.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PTbvD41MCVmnQWaobvHfCk
Minimal, narrow fix: internal_file_push_guard.py blocks any push while BEFUNDE.md, MARKETING-LOG.txt, RUNTIME_DAILY_CARE.md, STORE_CONTRACT.md and the _WARTUNG/ msix staging directory stay tracked (GITHUB-POLICY.md SS3). Untrack them here (files remain locally) and extend .gitignore with the guard's own patterns so this branch can be pushed. A broader repo-hygiene pass is already underway separately (chore/T-20260926-510472849-repo-hygiene, PR #3); this commit only unblocks the present branch and does not attempt that fuller cleanup. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PTbvD41MCVmnQWaobvHfCk
… on this branch The prior commit (eb1248a) untracked five files to unblock a push guard, but: (1) MARKETING-LOG.txt and RUNTIME_DAILY_CARE.md should not have been included -- MARKETING-LOG.txt is a deliberate public artifact (pyproject.toml project.url, a dedicated test), and RUNTIME_DAILY_CARE.md is genuine migration/ops documentation linked from README.md/README_de.md/README.es.md, not agent scratch state. Both restored (file + tracking). (2) STORE_CONTRACT.md and _WARTUNG/msix_staging/ untracking is correct and kept, but nothing rebuilt the tests/docs that read them -- a fresh clone of eb1248a failed 5 tests with FileNotFoundError (verified directly, not assumed). PRODUCT_BOUNDARIES.md, scripts/verify_product_boundaries.py, and tests/test_store_contract.py now cite/check STORE_LISTING.md/ WINDOWS_STORE_PREP.md/store_package.json only. Verified: full pytest suite in this worktree (270 passed, 5 skipped) AND a fresh clone of this commit with no locally-cached untracked files (same 270/5) -- specifically re-checked after the previous commit's fresh-clone run showed 5 failures, to confirm this one doesn't. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PTbvD41MCVmnQWaobvHfCk
|
Welcome! 👋 Thanks for your first pull request in this repository. A maintainer will review it soon. Please make sure:
Thanks for contributing! |
Collaborator
Author
|
Review (merge-reviewer, claude-opus) auf Head a574e4b:
|
This was referenced Sep 26, 2026
lukisch
added a commit
that referenced
this pull request
Sep 26, 2026
Follow-up to #3/#6 (T-20260926-510472849). Rebasing PR #3 onto master after #6 merged showed its actual hygiene work (STORE_CONTRACT.md/ _WARTUNG untrack + test rebuild, MARKETING-LOG.txt/RUNTIME_DAILY_CARE.md kept public) already landed via #6 -- only these .gitignore additions were still missing: TASKPLAN_STATUS_*.md pattern, plus a comment documenting why MARKETING-LOG.txt/RUNTIME_DAILY_CARE.md are deliberately NOT gitignore patterns (they must stay trackable). Verified: full pytest suite 270 passed, 5 skipped. Claude-Session: https://claude.ai/code/session_01PTbvD41MCVmnQWaobvHfCk Co-authored-by: Lukas Geiger <lukas@um-bruch.org> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
lukisch
added a commit
that referenced
this pull request
Sep 26, 2026
Team-lead review of #6 found the list-view Store screenshot showed real local installation paths verbatim, e.g. "C:\Users\User\OneDrive\.TOPICS\.SOFTWARE\CODING\REL-PUB_MethodenAnalyser\ MethodenAnalyser.exe" -- exposing the Windows username and internal OneDrive folder structure in a public repo. Root cause: SoftwareListItemDelegate.paint() shows the entry's real path as list-view secondary text whenever `notes` is unset, and the demo catalogue's _board_entries() never set it. Fix: pass notes="Lokal installiert" for demo entries. The path itself is untouched (still used for icon extraction/launch) -- only the visible secondary text changes. Applied to both generate_store_screenshots.py and the LaunchBoards sibling script (same latent bug, no tracked screenshots there yet since releases/windowsstore/screenshots-launchboards/ is gitignored -- fixed anyway so it can't leak once someone does track output from there). Regenerated and inspected all four screenshots (main-window, tabs, tiles, list) -- confirmed no path text visible in any of them. Verified: full pytest suite 270 passed, 5 skipped. Claude-Session: https://claude.ai/code/session_01PTbvD41MCVmnQWaobvHfCk Co-authored-by: Lukas Geiger <lukas@um-bruch.org> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
README/screenshots/main.pngpredated the reproducible Store screenshot generator and showed an empty, freshly-installed board ("Allgemein", 0 entries) instead of the app's real functionality (T-20260926-413277423).STORE_LISTING.mdnow point at the already-generator-maintained, populatedREADME/screenshots/store/main-window.png(Dev board) instead of a separate, easily-stale copy. Regenerated all four Store screenshots (current, no private paths visible -- generic program labels only). Removed the stalemain.png.eb1248a, an unblock-the-push workaround) had also untrackedMARKETING-LOG.txtandRUNTIME_DAILY_CARE.md-- both are legitimate public artifacts (pyproject.toml link + test, and a triple README-linked ops contract doc, respectively) and are restored here.STORE_CONTRACT.md/_WARTUNG/msix_staging/untracking is correct and kept, with the dependent tests/docs (PRODUCT_BOUNDARIES.md,scripts/verify_product_boundaries.py,tests/test_store_contract.py) rebuilt ontoSTORE_LISTING.md/WINDOWS_STORE_PREP.md/store_package.json.Test plan
🤖 Generated with Claude Code
https://claude.ai/code/session_01PTbvD41MCVmnQWaobvHfCk