Skip to content

chore: repo hygiene -- untrack BEFUNDE.md, extend .gitignore - #3

Closed
lukisch wants to merge 4 commits into
masterfrom
chore/T-20260926-510472849-repo-hygiene
Closed

lukisch wants to merge 4 commits into
masterfrom
chore/T-20260926-510472849-repo-hygiene

Conversation

@lukisch

@lukisch lukisch commented Sep 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Untracks BEFUNDE.md (pure agent handoff note, zero references elsewhere -- verified via repo-wide grep).
  • Extends .gitignore with the T-20260926-510472849 patterns (*MARKETING-LOG.txt, *STATUS-LOG.txt, *_DAILY_CARE.md, TASKPLAN_STATUS_*.md, STORE_CONTRACT.md, _WARTUNG/, _STAGING/) so future files of these classes aren't committed here again.
  • Deliberately left tracked in this PR: MARKETING-LOG.txt, STORE_CONTRACT.md, RUNTIME_DAILY_CARE.md, _WARTUNG/msix_staging/. Each is wired into a passing regression test (tests/test_metadata.py, tests/test_store_contract.py, tests/test_softwarecenter_sync.py) and/or linked from pyproject.toml/llms.txt/README as a public consistency contract. Untracking them here would break CI and dangling doc links -- that needs a coordinated follow-up (update the referencing tests/docs first), not a blind git rm --cached. Flagging as an open decision rather than silently doing either side.

Ticket: T-20260926-510472849 (pilot cleanup, per the ticket owner's explicit instruction not to mass-clean beyond this one repo).

Test plan

  • pytest tests/test_metadata.py tests/test_store_contract.py tests/test_ci_contract.py tests/test_product_boundaries.py -- 26 passed, unaffected by the BEFUNDE.md removal.

🤖 Generated with Claude Code

https://claude.ai/code/session_01PTbvD41MCVmnQWaobvHfCk

…ignore

T-20260926-510472849 (public GITHUB-POLICY.md SS3 enumeration missed
naming variants). BEFUNDE.md is a pure agent handoff note with zero
references elsewhere in the tree (verified) -- safe to untrack.

MARKETING-LOG.txt, STORE_CONTRACT.md, RUNTIME_DAILY_CARE.md and
_WARTUNG/ stay tracked in this pass: they are wired into
tests/test_metadata.py, tests/test_store_contract.py,
tests/test_softwarecenter_sync.py and pyproject.toml/llms.txt/README as
a public consistency contract, so untracking them here would break CI
and dangling doc links -- that needs a coordinated follow-up, not a
blind removal. The matching .gitignore patterns are added regardless,
so no NEW repo repeats the same naming pattern unreviewed.

Verified: full pytest run on the four affected suites (26 passed).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PTbvD41MCVmnQWaobvHfCk
@github-actions

Copy link
Copy Markdown

Welcome! 👋 Thanks for your first pull request in this repository.

A maintainer will review it soon. Please make sure:

  • Your changes are tested
  • Documentation is updated if needed
  • The PR description explains what and why

Thanks for contributing!

lukisch pushed a commit that referenced this pull request Sep 26, 2026
Minimal, narrow fix: internal_file_push_guard.py blocks any push while
BEFUNDE.md, MARKETING-LOG.txt, RUNTIME_DAILY_CARE.md, STORE_CONTRACT.md and
the _WARTUNG/ msix staging directory stay tracked (GITHUB-POLICY.md SS3).
Untrack them here (files remain locally) and extend .gitignore with the
guard's own patterns so this branch can be pushed. A broader repo-hygiene
pass is already underway separately (chore/T-20260926-510472849-repo-hygiene,
PR #3); this commit only unblocks the present branch and does not attempt
that fuller cleanup.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PTbvD41MCVmnQWaobvHfCk
…staging

Team-lead decision on T-20260926-510472849 (ecosystem bestand scan found
these agent-internal/build-artifact classes tracked in 105/143 public repos).
All three stay on disk locally (gitignored), nothing was deleted.

- MARKETING-LOG.txt: agent operational discoverability log. Retired from
  pyproject.toml project.url and llms.txt (llms.txt gained a CHANGELOG.md
  bullet instead -- same "public project history" role).
- STORE_CONTRACT.md: internal Store release/versioning bookkeeping.
  PRODUCT_BOUNDARIES.md and scripts/verify_product_boundaries.py now cite
  STORE_LISTING.md/WINDOWS_STORE_PREP.md only; tests/test_store_contract.py
  checks the same version-consistency invariant against store_package.json/
  pyproject.toml/SoftwareCenter.py/STORE_LISTING.md instead.
- _WARTUNG/msix_staging/: staged MSIX build output (manifest + packaged
  icons), matches GITHUB-POLICY.md SS3 "Build-Artefakte".

Deliberately NOT touched in this commit: RUNTIME_DAILY_CARE.md. Its content
is a legitimate migration/ops contract doc (not an agent scratch log) and is
directly linked from README.md/README_de.md/README.es.md, which another
worker is actively editing on this ticket right now -- flagging back for
confirmation before untracking a README-linked file out from under them.

Verified: full pytest suite 269 passed (down from 270: removed the now
file-less test_marketing_log_contract_and_invariants), AND a fresh worktree
checkout of this commit (no locally-cached untracked files) also passes --
the concern that a local-disk-only file could hide a CI-only FileNotFoundError
was checked directly, not assumed away.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PTbvD41MCVmnQWaobvHfCk
@lukisch

lukisch commented Sep 26, 2026

Copy link
Copy Markdown
Collaborator Author

Extended per team-lead decision: additionally untracked MARKETING-LOG.txt, STORE_CONTRACT.md, and _WARTUNG/msix_staging/ (staged MSIX build output), and rebuilt the tests/pyproject.toml/llms.txt/PRODUCT_BOUNDARIES.md contract onto the files that stay public (STORE_LISTING.md, WINDOWS_STORE_PREP.md, CHANGELOG.md, store_package.json). Verified two ways: full pytest suite in this working tree (269 passed, 5 skipped) AND in a completely fresh clone of this branch with no locally-cached untracked files (same 269/5) -- the second check specifically rules out a CI-only FileNotFoundError that a local run with leftover untracked files would hide.

Deliberately left tracked: RUNTIME_DAILY_CARE.md. Its content is a legitimate migration/ops contract document (not an agent scratch log despite the _DAILY_CARE.md name match) and is directly linked from README.md/README_de.md/README.es.md, which another worker (github-companion) is actively editing on a separate ticket right now. Flagging back to team-lead for confirmation before untracking a README-linked file out from under a concurrent edit.

…ETING-LOG.txt

Corrects the previous commit (a5e666c): team-lead review found
MARKETING-LOG.txt is a DELIBERATE public artifact here (pyproject.toml
project.urls."Marketing Log", tests/test_metadata.py asserting its
presence) -- not an accidental agent leak, matching the same pattern
found in usmc and zombie-killer-tray. Restored it fully (file tracking,
pyproject.toml, llms.txt, THIRD_PARTY_LICENSES.md wording, the dropped
test assertions and test_marketing_log_contract_and_invariants).

Keeps the other two untracks from a5e666c, unaffected by this reversal:
- STORE_CONTRACT.md: internal Store release/versioning bookkeeping.
  PRODUCT_BOUNDARIES.md and scripts/verify_product_boundaries.py now
  cite STORE_LISTING.md/WINDOWS_STORE_PREP.md only;
  tests/test_store_contract.py checks the same version-consistency
  invariant against store_package.json/pyproject.toml/SoftwareCenter.py/
  STORE_LISTING.md instead.
- _WARTUNG/msix_staging/: staged MSIX build output.

Still deliberately NOT touched: RUNTIME_DAILY_CARE.md (flagged back to
team-lead, awaiting confirmation -- content is a legitimate migration/ops
contract doc, README-linked, github-companion is actively editing README
on a separate ticket right now).

Verified: full pytest suite 270 passed, 5 skipped (270 = 269 from the
prior commit + the restored marketing-log test).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PTbvD41MCVmnQWaobvHfCk
@lukisch

lukisch commented Sep 26, 2026

Copy link
Copy Markdown
Collaborator Author

Correction (team-lead review): MARKETING-LOG.txt is fully restored (commit c08d009) -- it's a deliberate public artifact here (pyproject.toml project.urls, a dedicated presence test), matching the same pattern found in usmc and zombie-killer-tray. Only STORE_CONTRACT.md and _WARTUNG/msix_staging/ stay untracked. Re-verified: fresh clone of this branch, 270 passed/5 skipped.

lukisch added a commit that referenced this pull request Sep 26, 2026
* fix(docs): replace stale empty-board README screenshot

README/screenshots/main.png predated the reproducible Store screenshot
generator and showed a freshly-installed, empty board ("Allgemein", 0
entries) instead of the app's real functionality (T-20260926-413277423).

Repoint README (EN/DE/ES) and STORE_LISTING.md at the already-regenerated,
populated README/screenshots/store/main-window.png (Dev board, produced by
generate_store_screenshots.py) instead of maintaining a separate, easily
stale duplicate. Remove the stale main.png. Regenerated all four store
screenshots via `python generate_store_screenshots.py` to confirm they are
current and populated (no privacy-sensitive paths shown, only generic
program labels). LaunchBoards has no tracked README screenshot in this
repo, so there was nothing to check there.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PTbvD41MCVmnQWaobvHfCk

* chore: untrack agent-internal files blocking push (T-20260926-510472849)

Minimal, narrow fix: internal_file_push_guard.py blocks any push while
BEFUNDE.md, MARKETING-LOG.txt, RUNTIME_DAILY_CARE.md, STORE_CONTRACT.md and
the _WARTUNG/ msix staging directory stay tracked (GITHUB-POLICY.md SS3).
Untrack them here (files remain locally) and extend .gitignore with the
guard's own patterns so this branch can be pushed. A broader repo-hygiene
pass is already underway separately (chore/T-20260926-510472849-repo-hygiene,
PR #3); this commit only unblocks the present branch and does not attempt
that fuller cleanup.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PTbvD41MCVmnQWaobvHfCk

* fix(hygiene): restore MARKETING-LOG.txt/RUNTIME_DAILY_CARE.md, fix CI on this branch

The prior commit (eb1248a) untracked five files to unblock a push guard, but:
(1) MARKETING-LOG.txt and RUNTIME_DAILY_CARE.md should not have been included --
    MARKETING-LOG.txt is a deliberate public artifact (pyproject.toml project.url,
    a dedicated test), and RUNTIME_DAILY_CARE.md is genuine migration/ops
    documentation linked from README.md/README_de.md/README.es.md, not agent
    scratch state. Both restored (file + tracking).
(2) STORE_CONTRACT.md and _WARTUNG/msix_staging/ untracking is correct and kept,
    but nothing rebuilt the tests/docs that read them -- a fresh clone of eb1248a
    failed 5 tests with FileNotFoundError (verified directly, not assumed).
    PRODUCT_BOUNDARIES.md, scripts/verify_product_boundaries.py, and
    tests/test_store_contract.py now cite/check STORE_LISTING.md/
    WINDOWS_STORE_PREP.md/store_package.json only.

Verified: full pytest suite in this worktree (270 passed, 5 skipped) AND a
fresh clone of this commit with no locally-cached untracked files (same
270/5) -- specifically re-checked after the previous commit's fresh-clone
run showed 5 failures, to confirm this one doesn't.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PTbvD41MCVmnQWaobvHfCk

---------

Co-authored-by: Lukas Geiger <lukas@um-bruch.org>
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>

@lukisch lukisch left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review (merge-reviewer, claude-opus) auf Head c08d009: Nach dem Merge von #6 (546723b) ist der Hygiene-Teil inhaltlich schon auf master (gleiche Untracks von BEFUNDE/STORE_CONTRACT/_WARTUNG staging, gleicher Vertragsumbau). Gegen den neuen master gibt es jetzt einen Konflikt in CHANGELOG.md. Bitte rebasen. Übrig bleiben sollten nur die zusätzlichen .gitignore-Muster (*MARKETING-LOG.txt, DAILY_CARE.md, TASKPLAN_STATUS.md …) mit Erläuterung und ein bereinigter CHANGELOG-Eintrag ohne Doppelung zu #6. Ist danach nichts Eigenes mehr übrig, den PR schließen.

@lukisch

lukisch commented Sep 26, 2026

Copy link
Copy Markdown
Collaborator Author

Superseded: the substantive part landed via #6 (STORE_CONTRACT.md/_WARTUNG untrack + test rebuild, MARKETING-LOG.txt/RUNTIME_DAILY_CARE.md kept public). Only .gitignore patterns were still missing after rebasing onto master -- brought in via #7. Closing without merging.

@lukisch lukisch closed this Sep 26, 2026
lukisch added a commit that referenced this pull request Sep 26, 2026
Follow-up to #3/#6 (T-20260926-510472849). Rebasing PR #3 onto master
after #6 merged showed its actual hygiene work (STORE_CONTRACT.md/
_WARTUNG untrack + test rebuild, MARKETING-LOG.txt/RUNTIME_DAILY_CARE.md
kept public) already landed via #6 -- only these .gitignore additions
were still missing: TASKPLAN_STATUS_*.md pattern, plus a comment
documenting why MARKETING-LOG.txt/RUNTIME_DAILY_CARE.md are
deliberately NOT gitignore patterns (they must stay trackable).

Verified: full pytest suite 270 passed, 5 skipped.


Claude-Session: https://claude.ai/code/session_01PTbvD41MCVmnQWaobvHfCk

Co-authored-by: Lukas Geiger <lukas@um-bruch.org>
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant