fix(privacy): neutralize local install paths in Store screenshots - #8
Merged
Merged
Conversation
Team-lead review of #6 found the list-view Store screenshot showed real local installation paths verbatim, e.g. "C:\Users\User\OneDrive\.TOPICS\.SOFTWARE\CODING\REL-PUB_MethodenAnalyser\ MethodenAnalyser.exe" -- exposing the Windows username and internal OneDrive folder structure in a public repo. Root cause: SoftwareListItemDelegate.paint() shows the entry's real path as list-view secondary text whenever `notes` is unset, and the demo catalogue's _board_entries() never set it. Fix: pass notes="Lokal installiert" for demo entries. The path itself is untouched (still used for icon extraction/launch) -- only the visible secondary text changes. Applied to both generate_store_screenshots.py and the LaunchBoards sibling script (same latent bug, no tracked screenshots there yet since releases/windowsstore/screenshots-launchboards/ is gitignored -- fixed anyway so it can't leak once someone does track output from there). Regenerated and inspected all four screenshots (main-window, tabs, tiles, list) -- confirmed no path text visible in any of them. Verified: full pytest suite 270 passed, 5 skipped. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PTbvD41MCVmnQWaobvHfCk
|
Welcome! 👋 Thanks for your first pull request in this repository. A maintainer will review it soon. Please make sure:
Thanks for contributing! |
Collaborator
Author
|
Review (merge-reviewer, claude-opus) auf Head 897106a: Alle vier Screenshots angesehen. In der Listenansicht (Dev, office) steht als Zweitzeile jetzt „Lokal installiert“ statt lokaler Pfade, die Kachelansichten zeigen keine Pfade. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Team-lead review of #6 found the list-view Store screenshot showed real local installation paths verbatim (e.g.
C:\Users\User\OneDrive\.TOPICS\.SOFTWARE\CODING\REL-PUB_MethodenAnalyser\MethodenAnalyser.exe) -- exposing the Windows username and internal OneDrive folder structure.Root cause: `SoftwareListItemDelegate.paint()` shows the entry's real path as list-view secondary text whenever `notes` is unset, and the demo catalogue's `_board_entries()` never set it.
Fix: pass `notes="Lokal installiert"` for demo entries in both `generate_store_screenshots.py` and the LaunchBoards sibling script (same latent bug there too -- no tracked screenshots yet since its output dir is gitignored, fixed anyway). The path itself is untouched (still used for icon extraction/launch), only the visible secondary text changes.
Regenerated and visually inspected all four screenshots (main-window, tabs, tiles, list) -- confirmed no path text visible in any of them.
Test plan
🤖 Generated with Claude Code
https://claude.ai/code/session_01PTbvD41MCVmnQWaobvHfCk