Skip to content

fix(form_fit): measure a label number in a format the text export does not write - #472

Merged
airmang merged 1 commit into
mainfrom
fix/form-fit-label-number-format-unknown
Oct 16, 2026
Merged

airmang merged 1 commit into
mainfrom
fix/form-fit-label-number-format-unknown

Conversation

@airmang

@airmang airmang commented Oct 16, 2026

Copy link
Copy Markdown
Owner

What

Some paragraphs stopped FormFit and the page estimate with a KeyError. These are paragraphs whose number label has a character shape of its own, is measured by Hancom (useInstWidth), and uses a number format the text export does not write (KOREAN_DIGIT, HANGUL, ...). Such a number now counts as one Hangul syllable, as it already does when Hancom does not measure the label.

Tests

test_a_number_label_in_a_format_the_text_export_does_not_write_is_estimated takes the Hancom-saved bullet and number label fixture and gives every number such a format, a measured width and a character shape of its own. It fails before this change with the KeyError and passes after, with and without the line caches.

🤖 Generated with Claude Code

@airmang airmang left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

900b0dc 검토 완료. 번호 형식의 지원 집합 검사와 한글 한 글자 대체 폭, 기존 ^N 처리를 확인했습니다. 별도 Python 3.12 체크아웃에서 관련 테스트 4개가 통과했고 검토 범위에서 재현된 코드 결함은 찾지 못했습니다. 해당 head의 GitHub 검사 13개는 모두 성공했습니다. 다만 #470/#471 병합 뒤 최신 main dae1ee2c60014e3ed6d1c290bc79e7d64d73a710과의 병합 충돌이 있어 이번에는 보류합니다. git merge-tree와 GitHub의 CONFLICTING 상태로 확인했으며, 충돌 파일은 CHANGELOG.md입니다. main을 merge해 양쪽 변경을 보존하고 충돌을 해결한 최신 head에서 검사를 통과하면 다시 검토하겠습니다.

…s not write

A paragraph whose number label has a character shape of its own and a number
format the text export does not write (KOREAN_DIGIT, HANGUL, ...) stopped
FormFit and the page estimate with a KeyError when Hancom measures the label
(useInstWidth). Such a number now counts as one Hangul syllable, as it does
when Hancom does not measure the label.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@airmang
airmang force-pushed the fix/form-fit-label-number-format-unknown branch from 900b0dc to 50b9519 Compare October 16, 2026 06:19

@airmang airmang left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

50b9519 재검토 완료. 이전 검토와 range-diff상 기능 변경 없이 main을 반영했고, 번호 형식 미지원 시 KeyError 대신 한글 한 글자 폭을 사용하는 경로와 기존 ^N 처리를 확인했습니다. 최신 main 6f80e69(#475/#468 포함)을 합친 별도 체크아웃에서 번호·탭·넓은 개체·줄 배치 관련 테스트 841개가 통과했습니다. 이 head의 13개 CI 검사와 실제 Python 3.12 로그(6759 passed, 18 skipped, 1 xfailed, coverage 89.97%; Ruff·mypy·Pyright·공개 게이트 성공)를 확인했습니다. 검토 범위에서 재현된 결함이나 미해결 리뷰 문제를 발견하지 못했습니다. 선형 이력 보호를 지키는 squash 병합으로 처리합니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant