Skip to content

feat(form_fit): lay out 신명 태명조, 신명 견고딕 and 한양그래픽 at Hancom's advances - #483

Merged
airmang merged 6 commits into
mainfrom
feat/form-fit-sinmyeong-taemyeongjo
Oct 16, 2026
Merged

airmang merged 6 commits into
mainfrom
feat/form-fit-sinmyeong-taemyeongjo

Conversation

@airmang

@airmang airmang commented Oct 16, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Hancom Office lays out 신명 태명조, 신명 견고딕 and 한양그래픽 as faces of their own. It does not substitute 한컴바탕 or another face for them. 신명 태명조 and 한양그래픽 use 2048 units, 신명 견고딕 1000. In 신명 태명조, digits take 0.71 em and parentheses half an em.
  • FormFit and the page estimate now use their advances for the base glyphs and the standard glyph sets. Before, no table listed these faces, so their glyphs took their class's average width.
  • Two Hancom-saved fixtures hold cells of 24 glyphs in each face, each at the two widths where its line count changes, at 10 and 30 pt.

Test plan

  • The new fixture tests fail before the change and pass after it
  • Lint, format, type checks and the other repository gates
  • Full test suite: no new failures

🤖 Generated with Claude Code

airmang and others added 2 commits October 16, 2026 15:29
Hancom Office lays out 신명 태명조 as a face of its own, in 2048 units, and not as 한컴바탕 or another face it substitutes: digits take 0.71 em and parentheses half an em. FormFit and the page estimate now take its advances for the base glyphs and the standard sets; before, the face was listed nowhere and its glyphs took their class's average width.

A Hancom-saved fixture holds cells of 24 glyphs in the face at 10 and 30 pt.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Hancom Office lays these two out as faces of their own too, 신명 견고딕 in 1000 units and 한양그래픽 in 2048, not as 한컴바탕. FormFit and the page estimate now take their advances for the base glyphs and the standard sets.

A Hancom-saved fixture holds cells of 24 glyphs in each face at 10 and 30 pt.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@airmang airmang changed the title feat(form_fit): lay out 신명 태명조 at Hancom's advances feat(form_fit): lay out 신명 태명조, 신명 견고딕 and 한양그래픽 at Hancom's advances Oct 16, 2026

@airmang airmang left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

347a4c7 검토 완료. 3개 글꼴의 units-per-em, 기본/확장 글리프 폭과 기존 대체 경로를 검토했습니다. 각 표 1679개 글리프에서 서로 다른 폭으로 중복된 문자는 없었고, FormFit 테스트 133개가 통과했습니다. 해당 최신 head의 CI 전체 성공과 실제 Python 3.12 로그(6759 passed, 18 skipped, 1 xfailed; coverage 기준 및 Ruff·mypy·Pyright·공개 저장소 게이트 통과)를 확인했습니다. 검토 범위에서 재현된 코드 결함은 찾지 못했습니다. 다만 #475/#468/#472 병합 후 최신 main 0193c010218cb5c0abeed891be2aab4ec9de2f80과 CHANGELOG.md 내용 충돌이 발생함을 git merge-tree로 확인해 병합을 보류합니다. main의 변경 기록을 함께 보존하여 충돌을 해결한 뒤 새 head의 검사와 통합 결과를 다시 검증해야 합니다.

@airmang airmang left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3개 글꼴의 units-per-em, 기본/확장 글리프 폭 및 중복 문자 충돌 부재를 검토했습니다. 삽입 위치 정리 전후 데이터는 동일합니다. 충돌은 양쪽 기록과 테스트를 보존해 해결했고, 재배치 전후 함수·데코레이터·데이터의 의미가 같음을 대조했습니다. Python 3.10–3.14 전체 CI, CodeQL, 의존성 검사가 모두 성공했습니다. 같은 커밋의 중복 PR 테스트 실행은 취소하고 push 매트릭스 성공을 확인했습니다. 최종 통합본의 관련 테스트 1,692개도 통과했습니다. 검토한 head를 지정하여 squash 병합합니다.

@airmang
airmang merged commit 5606dfa into main Oct 16, 2026
8 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant