Repository navigation
feat(form_fit): lay glyphs out at the advances of Hancom Office 2024 - #471
Merged
Merged
Conversation
FormFit and the page estimate now follow Hancom Office 2024's layout of these glyphs: - ! is half an em in every face, rounded and scaled as any other glyph. - 함초롬돋움's spacing modifier letters, general punctuation (but the quotation marks) and currency symbols take 함초롬바탕's advances, and so do the faces that fall back on 함초롬돋움. - HY헤드라인M takes the design advances of the version Hancom Office 2024 ships; 휴먼명조 and 휴먼고딕 the advances Hancom lays them out at, in 1024 units per em. The three carry Hancom's advances for their Greek and Cyrillic letters and the glyphs they lack. - The grave accent in HY견고딕, HY울릉도M, HY견명조 and HY동녘M is 0.584 em, and HY울릉도M falls back on 함초롬바탕. The glyph-width, symbol-row and HY헤드라인M fixtures are re-saved by Hancom Office 2024, and a new one holds 함초롬돋움's punctuation and ! in three faces. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
At 10 and 40 pt two neighbouring units in 1024 can give a glyph the same width; laid out at 80 pt (an em of 2000) they do not. Seven glyphs of 휴먼명조 and eleven of 휴먼고딕 are a unit narrower than the tables had them, among them the parentheses and the slash (320, not 321: 468 at 15 pt, not 472). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
airmang
commented
Oct 16, 2026
airmang
left a comment
Owner
Author
There was a problem hiding this comment.
4b99ba8 검토 완료. 2024 글꼴 advance 변경, units-per-em/vertical metrics 일치, 글꼴 fallback 경로와 !의 반 em 처리 및 golden fixture 변경을 확인했습니다. glyph-table 데이터에 서로 다른 폭을 덮어쓰는 중복 문자도 없었습니다. 원래 head에서 FormFit 테스트 130개가 통과했고, #470이 병합된 최신 main 5e6ff06f68475036d93151d4dfea5869f29a17f4와 합친 검증 트리에서는 FormFit/쪽 수 추정 테스트 1,509개가 모두 통과했습니다. head의 CI 13개가 모두 성공했고 실제 Python 3.12 로그에서도 6,743 passed / 18 skipped / 1 xfailed, coverage 89.97%, mypy/Pyright 성공을 확인했습니다. 병합을 막는 결함을 찾지 못했습니다.
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
FormFit and the page estimate now follow Hancom Office 2024's layout of these glyphs. This commit was pushed to the branch of #466 after that PR had been merged, so it never reached
main; it is re-applied here on top ofmainunchanged.!is half an em in every face, rounded and scaled as any other glyph.Tests
The glyph-width, symbol-row and HY헤드라인M fixtures are re-saved by Hancom Office 2024 (scrubbed), and a new one holds 함초롬돋움's punctuation and
!in three faces.🤖 Generated with Claude Code