Repository navigation
Fix main: pass the new PlacesMap props in the filter presets test - #334
Merged
AnayDhawan merged 1 commit intoNov 2, 2026
Merged
Conversation
Contributor
|
@propcgamer20-png is attempting to deploy a commit to the studentsuite Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Repairs
main: the CI run after #333 merged fails typecheck, build and one unit test.#331 added a
PlacesMaptest (PlacesMap filter presets) that renders<PlacesMap places={PLACES} />. #333 madecities,defaultCenteranddefaultZoomrequired props onPlacesMap. The two branches did not conflict textually, so they merged cleanly, but together they fail:lint-typecheckandbuild:places-map.test.tsx(305,13): error TS2739: ... missing the following properties from type 'PlacesMapProps': cities, defaultCenter, defaultZoomunit-tests:PlacesMap filter presets > narrows the results to the preset's type and sets it in the URLfails.The fix passes the same three props the other
PlacesMaptests already pass. Only the test file changes.Proof
On this branch:
npm run typecheckclean,prettier --checkclean,npm run test:unitall pass: 70 files, 659 tests passed.I should have re-run the combined tests after #331 landed; my earlier merge test covered #330 to #332 only, before #333 existed.
Type of change