Skip to content

Fix main: pass the new PlacesMap props in the filter presets test - #334

Merged
AnayDhawan merged 1 commit into
StudentSuite:mainfrom
propcgamer20-png:fix/main-places-map-test
Nov 2, 2026
Merged

AnayDhawan merged 1 commit into
StudentSuite:mainfrom
propcgamer20-png:fix/main-places-map-test

Conversation

@propcgamer20-png

Copy link
Copy Markdown
Member

What this changes

Repairs main: the CI run after #333 merged fails typecheck, build and one unit test.

#331 added a PlacesMap test (PlacesMap filter presets) that renders <PlacesMap places={PLACES} />. #333 made cities, defaultCenter and defaultZoom required props on PlacesMap. The two branches did not conflict textually, so they merged cleanly, but together they fail:

  • lint-typecheck and build: places-map.test.tsx(305,13): error TS2739: ... missing the following properties from type 'PlacesMapProps': cities, defaultCenter, defaultZoom
  • unit-tests: PlacesMap filter presets > narrows the results to the preset's type and sets it in the URL fails.

The fix passes the same three props the other PlacesMap tests already pass. Only the test file changes.

Proof

On this branch: npm run typecheck clean, prettier --check clean, npm run test:unit all pass: 70 files, 659 tests passed.

I should have re-run the combined tests after #331 landed; my earlier merge test covered #330 to #332 only, before #333 existed.

Type of change

  • Code or fix
  • New public place(s)
  • New or updated benefit guide
  • New or updated resource link
  • Docs

@vercel

vercel Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

@propcgamer20-png is attempting to deploy a commit to the studentsuite Team on Vercel.

A member of the Team first needs to authorize it.

@AnayDhawan
AnayDhawan merged commit 6db3aa7 into StudentSuite:main Nov 2, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants