Repository navigation
Wire the contribution leaderboard, city switcher and home distance into their pages - #335
Merged
AnayDhawan merged 2 commits intoNov 2, 2026
Conversation
Contributor
|
@propcgamer20-png is attempting to deploy a commit to the studentsuite Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Part of #313. Wires three of the standalone components that no page imported yet; each checkbox below is a separate item in that issue.
ContributionLeaderboardon/about(src/app/about/page.tsx): ranksadded_byacross the dataset already loaded on that page, no new data or API.CitySwitcherin the homepage hero (src/components/home/hero.tsx): "Jump to a city" going to/city/<slug>, fed by thegetCities(places)the hero already computes.RouteEtaCardin the pin popup:PlacesMapnow passes the signed-in visitor's saved home ({ lat, lng }) toMapView, which passes it toClusteredMarkersandPinPopup. With a home set, the popup shows the straight-line distance and a rough walking time; without one it renders nothing.Not touched, and why:
PlaceReviewBadgeandRecentAdditionsFeedneed data the schema does not have (ratings, added-on dates);HeatmapToggleneeds map rendering first;PlaceDetailDrawer,ComparePlacesSheet,SharePlaceCardandPlacePhotoGalleryneed a design decision on where they open from;CategoryIconwould change the pin-matching legend dots. #313 therefore stays open.Proof
pin-popup.test.tsx(+2: distance shown with a home, nothing without),about/page.test.tsx(leaderboard heading renders),home/hero.test.tsx(the jump-to-city combobox is present).npm run typecheck,npm run lint: clean.npm run test:unit: 72 files, 663 tests pass.Not verified
I did not open the pages in a browser, so the layout of the new switcher in the hero and the extra popup line on a small screen are unchecked; the tests cover rendering and props only.
Type of change