Repository navigation
Get theme updates - #96
Merged
Merged
Conversation
Bring in `site-commons` at `9216e48`. The theme now compiles its styles with Dart Sass (SpineEventEngine/site-commons#40) and uses `@use` and `@forward` instead of `@import` (SpineEventEngine/site-commons#41). It also serves jQuery as a file instead of inlining it into every page (SpineEventEngine/site-commons#39). As the README asks, `go.sum` keeps only the entries of the new `site-commons` version. Part of SpineEventEngine/site-commons#38. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟢 Approved
No active review issues are reported for the documentation preview’s site-commons dependency update.
No open issues 🎉
What changed in this PR
Updates the documentation preview’s site-commons dependency from b79100d to 9216e48, bringing in Dart Sass support, Sass module syntax, and separately served jQuery.
Changes:
- Advances the theme dependency without changing other module requirements.
- Replaces obsolete
site-commonschecksums with entries for the new version.
| File | Description |
|---|---|
docs/_preview/go.sum |
Updates theme checksums and removes older theme entries. |
docs/_preview/go.mod |
Pins the preview to the updated site-commons revision. |
Review effort: Balanced
Run `./config/pull`, which moves `config` to `f5a8d40` and `.agents/shared` to `017c8d3`, the tips of their `master` branches. The `.agents/shared` pin is force-added, because `.gitmodules` sets `ignore = all` for it. The pull brings in config's current templates: - `.claude/settings.json` allows `git commit` and `git push`, and asks before a force push. - `AGENTS.md` and `init-submodules`: a fresh checkout now floats the shared submodules to their branch tips instead of their pinned commits. - `check-links.yml` gets the comments of config's Dart Sass steps. Local edits stay. The local edits to `check-links.yml`, the Hugo v0.169.0 bump and the Dart Sass steps, are already in config's template. The other updated files had no local edits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
alexander-yevsyukov
enabled auto-merge (squash)
October 30, 2026 17:51
alexander-yevsyukov
disabled auto-merge
October 30, 2026 18:02
The old theme inlined jQuery into the `<head>` of every page, and Lychee extracted no links past it: 7 unique links from the 95 preview pages. With jQuery served as a file (SpineEventEngine/site-commons#39), Lychee reads whole pages and finds 794 unique links. Thirteen of them are broken. - The Stack Overflow answer link redirects to a `/questions/` URL, which answers bots with 403. `lychee.toml` excludes such URLs, so link to the answer by its `/questions/` URL. - The other twelve are in the docs of `SpineEventEngine/validation`, which only that repository can fix. A new `.lycheeignore` lists them. Lychee reads it from the repository root, and `./config/pull` does not overwrite it, unlike `lychee.toml`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
site-commonsindocs/_previewfromb79100dto9216e48, the latestmaster. With it, the documentation preview moves from LibSass to Dart Sass.The update brings in:
@importto@usesite-commons#41: the theme styles use@useand@forwardinstead of@import./js/jquery.jsinstead of being inlined into every page.As the README asks,
go.sumkeeps only the entries of the newsite-commonsversion. No other module ingo.modchanged.docs/go.moddoesn't pinsite-commons.Part of SpineEventEngine/site-commons#38.
configand.agents/sharedThe second commit runs
./config/pull. It movesconfigfrom94a9e08tof5a8d40and.agents/sharedfromfefe0edto017c8d3, the tips of theirmasterbranches. The.agents/sharedpin is force-added because.gitmodulessetsignore = allfor it.The pull brings in config's current templates:
.claude/settings.jsonallowsgit commitandgit push, and asks before a force push.AGENTS.mdandinit-submodules: a fresh checkout now floats the shared submodules to their branch tips instead of their pinned commits.check-links.ymlgets the comments of config's Dart Sass steps.Local edits stay:
settings.json,AGENTS.md, andinit-submodulesmatched config's old templates exactly, so they had no local edits.check-links.ymlare the Hugo v0.169.0 bump (Move to Hugo v0.169.0 and the latestsite-commons#94) and the Dart Sass steps (Prepare for Dart Sass #95). Config's template already has both. A three-way merge shows that config's version only adds comments to them.lychee.toml,.gitignore,CLAUDE.md, and the other workflows, came out unchanged.Link check
check-linkshas checked almost nothing until now. The old theme inlined jQuery into the<head>of every page, and Lychee extracted no links past it. From the 95 preview pages it found 7 unique links, all of them in the<head>. With jQuery in its own file, Lychee reads whole pages and finds 794 unique links, 13 of them broken. The third commit fixes the check:The Stack Overflow link in
docs/guides/validation.mdnow uses the answer's/questions/URL, whichlychee.tomlexcludes because Stack Overflow answers bots with 403.The other 12 links are in the docs of
SpineEventEngine/validation, and only that repository can fix them. A new.lycheeignorelists them../config/pulldoesn't overwrite it, unlikelychee.toml. Fix broken links in the documentation validation#340 tracks fixing the links, and Remove the validation links from.lycheeignoreonce they are fixed #97 tracks removing the patterns afterwards.These are the 12 links:
.agents/running-builds.mdand.agents/documentation-guidelines.mdinvalidation, which moved into the sharedguidelinessubmodule.EMBEDDING.mdandbin/inembed-code-go, which no longer exist.plugins.gradle.org/plugin/io.spine.validation, which returns 400.06-developers-guide/,developer/, andtypical_custom_option.jpg, which resolve outside the module's pages.Locally, with Lychee 0.24.2 against the preview on port 1313, as CI runs it: 13 errors before the fix, 0 after.
Build warnings
hugo -e developmentindocs/_preview, with Hugo v0.169.0 and Dart Sass 1.99.0:master)css.Sass: libsass was deprecated in Hugo v0.153.0 …--ignoreCacheCSS comparison
I parsed
public/main.cssfrom both builds into rules and compared them: 4,841 rules before, 4,843 after. Shared selectors keep their order. The differences are below.Expected:
rgb(251.5, 252, 252.5)for#fcfcfd. Rounded, they differ by at most 1 per channel, mostly in Bootstrap's.table-*variables.\f101-style escapes.*incalc().navy,hsla(0,0%,100%,.5),rgba(0,0,0,0)fortransparent.calc()folded to a value:.ratio-4x3,.ratio-16x9,.ratio-21x9(75%,56.25%,42.857…%), and.toc-col(calc(50vw - 380px)).border-radius: 1px. LibSass emitted the invalidcalc($indicator-line-height/2), which browsers drop..h1–.h6and.smallvariants of theme selectors. 46 selectors are gone, along with the theme's declarations on bare.h1–.h6and.small. Bootstrap's own rules for these classes stay. No preview page uses these classes.Not on the expected list, but intended:
@font-facenow takes its EOTsrcfromfonts/robotomono/. The old path,fonts/roboto/roboto-mono-v5-latin-500.eot, doesn't exist. The fix is site-commonsae0e4fa, part of Add "Download PDF" button for the architecture diagram #41. Only IE loads EOT, so modern browsers see no change.The rest of the build output differs only in:
main.js;Browser check
I checked three pages:
/docs/introduction/naming-conventions/;/docs/validation/user/01-getting-started/generated-code/.On each page, I loaded the old
main.cssinto the same DOM and compared the computed styles of every element,::before, and::afterwith the new CSS. I did this in both code themes, at 1024 px and 375 px wide. The only difference is the code-tab indicator'sborder-radius, from0pxto1px. jQuery 3.6.0 loads from/js/jquery.js, and both the code tabs and the code theme toggle work.🤖 Generated with Claude Code