Repository navigation
Run Check Links when .lycheeignore changes - #826
Merged
Merged
Conversation
Sites now keep their site-specific Lychee exclusions in a repo-local `.lycheeignore`, which `./config/pull` leaves alone. A PR that only adds or removes an ignored link should still get its links checked. The line matches the one spine.io added to its copy, so the next `./config/pull` there keeps it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
There was a problem hiding this comment.
🟢 Approved
No active review issues are identified for the change that triggers Check Links when .lycheeignore changes.
No open issues 🎉
What changed in this PR
Ensures the shared Check Links workflow runs when a pull request changes repository-local Lychee exclusions.
Changes:
- Adds
.lycheeignoreto the pull request path filters. - Leaves link-checking behavior unchanged; only the workflow’s trigger coverage expands.
| File | Description |
|---|---|
.github/workflows/check-links.yml |
Triggers Check Links for changes to .lycheeignore. |
Review effort: Balanced
alexander-yevsyukov
added a commit
to SpineEventEngine/SpineEventEngine.github.io
that referenced
this pull request
Nov 2, 2026
Brings in SpineEventEngine/config#826 and #827. #826 adds the `.lycheeignore` trigger to `check-links.yml`, which this repo's copy already has. #827 makes `Check Links` also find Hugo configs under `_preview/`. This repo's copy doesn't have that yet, and doesn't need it: the site's config is in `site/config/_default/`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sites now keep site-specific Lychee exclusions in a repo-local
.lycheeignore, which./config/pulldoesn't overwrite. See SpineEventEngine/documentation#96 and SpineEventEngine/SpineEventEngine.github.io#564.check-links.ymldidn't trigger on that file, so a PR that only adds or removes an ignored link skipped Check Links. This PR adds- '.lycheeignore'toon.pull_request.paths, after- 'lychee.toml'.The
Check linksstep runs Lychee at the repo root with noworking-directory, which is where Lychee reads.lycheeignoreby default. The job's behavior doesn't change, only when it runs.Consumers
migratecopies this workflow over each Hugo site's copy, so the line must match the consumers' copies byte for byte:SpinePublishingfromtool-base#564 already adds this exact line (commit745f1b0). With this PR, config'scheck-links.ymlis byte-identical to spine.io's on theget-theme-updates-dart-sassbranch, so the next./config/pullthere keeps the line..lycheeignorebut not the trigger line. It picks the line up on its next./config/pull.Overlap with #825
#825 (
check-links-node24) edited the same file and is already merged. This branch starts frommasterafter that merge, so the two don't conflict.Verification
actionlint1.7.12 reports nothing forcheck-links.yml.cmpagainst spine.io's copy (localget-theme-updates-dart-sass, which includes745f1b0) shows the files are identical.🤖 Generated with Claude Code