Repository navigation
Update the documentation module and drop .lycheeignore - #565
Merged
Merged
Conversation
Brings in SpineEventEngine/documentation#96 and #98. They fix the Stack Overflow link and, through SpineEventEngine/validation#341, the eight broken links in the validation docs. Lychee now passes on all nine links without the ignore file, so the file goes. `check-links.yml` keeps its `.lycheeignore` trigger, which comes from `config`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟢 Approved
No active review issues block the documentation dependency updates and removal of link-check exclusions.
No open issues 🎉
What changed in this PR
Updates the site’s imported documentation to include upstream link fixes, allowing removal of the temporary Lychee exclusions introduced in #564.
Changes:
- Advances
documentation/docsto3346b3fand itsvalidation/docsdependency to2754355. - Adds checksums for both updated modules.
- Deletes
.lycheeignorenow that the affected links are fixed; theme and npm dependencies remain unchanged.
| File | Description |
|---|---|
site/go.sum |
Adds checksums for the updated documentation modules. |
site/go.mod |
Updates documentation and validation module versions. |
.lycheeignore |
Removes obsolete exclusions for broken documentation links. |
Review effort: Balanced
Brings in SpineEventEngine/config#826 and #827. #826 adds the `.lycheeignore` trigger to `check-links.yml`, which this repo's copy already has. #827 makes `Check Links` also find Hugo configs under `_preview/`. This repo's copy doesn't have that yet, and doesn't need it: the site's config is in `site/config/_default/`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
github.com/SpineEventEngine/documentation/docsHugo module from3045fa4to3346b3f, the merge of SpineEventEngine/documentation#98. It brings in:Go's minimum version selection also moves
validation/docsfrom6465029to2754355, the versiondocumentationnow requires.site-commonsand the npm packages stay where they are..lycheeignore#564 added
.lycheeignorewith 9 patterns for links broken in the imported docs. All 9 now pass, so this PR deletes the file. I ran Lychee 0.24.2 withlychee.tomlover the development build, from a directory with no.lycheeignore, so every pattern's link got checked:lychee.toml)./docs/validation/developer/…and/docs/validation/user/05-custom-validation/typical_custom_option.jpg, which returns 200.check-links.ymlkeeps its- '.lycheeignore'trigger. It comes fromconfig(SpineEventEngine/config#826), and a site may need the file again later.Verification
hugo --minifywith an empty resource directory, so Sass compiles from scratch: no warnings.npm testinsite/: 42 tests pass.🤖 Generated with Claude Code