Repository navigation
refactor(builder): name the DLSS license flag apart from the dialog text, and finish its comment - #2565
refactor(builder): name the DLSS license flag apart from the dialog text, and finish its comment#2565LNDF wants to merge 1 commit into
Conversation
…ext, and finish its comment Review nits on NotRexed#2528: the field dlssLicense sat beside the DlssLicense constant (the license dialog's text) in MainWindow, and its comment read as cut off. The field is dlssLicenseAccepted now, and the comment says what the old record did in full. No change in behaviour. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Joey-Magnus
left a comment
Joey-Magnus
left a comment
There was a problem hiding this comment.
I merged this into current main. Nothing else in builder/ or tests/ refers to dlssLicense by name: I grepped main and the open #2591 branch, so the rename breaks no source-reading check. tests/test_ffx_sdk.py passes. The .NET fixture (tests/builder_dlss_update_test.cs) needs the SDK, which I don't have here, so for that I'm relying on your run and the Builder package job, which is green. I also merged it on top of #2591 and #2553 and it applies cleanly with both, so the three can land in any order.
The red Python shards fail only test_env_on (HOS_FPS_LOG in host/oot_high_fps.c, fixed on main since), test_psychov35 and test_pcache_header_read on Windows. None of them come from this change, and a re-run should clear them.
The two nits from the review of #2528, which merged before I could address them.
dlssLicensesat beside the existingDlssLicenseconstant (the license dialog's text) inMainWindow.xaml.cs. It isdlssLicenseAcceptednow.No change in behaviour. The
UpdateBuildfixture (tests/builder_dlss_update_test.cs, run on .NET 10 here) still passes its 63 checks;python -I -B tests/run_all.pyon Linux: nothing new fails.🤖 Generated with Claude Code