Skip to content

fix: readme's work/ffx-sdk, and the build log names an FSR 4 tick without AMD's license - #2553

Open
roblesleo wants to merge 1 commit into
NotRexed:mainfrom
roblesleo:fix/fsr4-followup
Open

roblesleo wants to merge 1 commit into
NotRexed:mainfrom
roblesleo:fix/fsr4-followup

Conversation

@roblesleo

Copy link
Copy Markdown
Contributor

Follow-up to #1866's review.

  • readme: the default HOOKSHOT_FFX_SDK folder read work<0x0C>fx-sdk (a \f had turned into a form feed). It reads work/ffx-sdk now.
  • Windows Builder: an AMD FSR 4 tick saved before the builder asked for AMD's license still builds with FSR 4 and fetches nothing, as before. The build log now says so in one line: "AMD's license not accepted yet: tick AMD FSR 4 again to have its runtime fetched". tests/test_ffx_sdk.py's source check covers the line.

Ran locally on Windows: test_ffx_sdk, test_make_game_ngx, test_builder_dlss_update and dotnet build of the Builder, all passing.

🤖 Generated with Claude Code

…ld log names an FSR 4 tick without AMD's license

Follow-up to NotRexed#1866's review. The readme read `work<0x0C>fx-sdk`; it reads `work/ffx-sdk` now. A Windows Builder FSR 4
tick saved before the builder asked for AMD's license builds with FSR 4 and fetches nothing, as intended: the build log
now says so in one line ("AMD's license not accepted yet: tick AMD FSR 4 again to have its runtime fetched"), and
tests/test_ffx_sdk.py's source check covers it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@Joey-Magnus Joey-Magnus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged this into current main. tests/test_ffx_sdk.py and test_make_game_ngx.py pass, and tests/test_env_on.py passes too. I checked that main's readme still has the form feed: line 839 reads work^Lfx-sdk in cat -A, so the readme fix is still needed.

The new log line at MainWindow.xaml.cs:1012 fires only in Run when the tick is on, fsr is false and the license wasn't accepted. That is exactly the legacy-tick case, where StartBuild passes --fsr without the fetch. With #2591 on top, UpdateBuild also passes --fsr for a saved tick without the license, and the message still fits that path. It merges cleanly with #2591 and #2565 in either order.

The red jobs are test_env_on (HOS_FPS_LOG, fixed on main since), test_psychov35 and test_pcache_header_read on Windows. None of them touch the Builder, so a re-run should turn them green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants