Repository navigation
Conversation
…ld log names an FSR 4 tick without AMD's license Follow-up to NotRexed#1866's review. The readme read `work<0x0C>fx-sdk`; it reads `work/ffx-sdk` now. A Windows Builder FSR 4 tick saved before the builder asked for AMD's license builds with FSR 4 and fetches nothing, as intended: the build log now says so in one line ("AMD's license not accepted yet: tick AMD FSR 4 again to have its runtime fetched"), and tests/test_ffx_sdk.py's source check covers it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Joey-Magnus
left a comment
There was a problem hiding this comment.
I merged this into current main. tests/test_ffx_sdk.py and test_make_game_ngx.py pass, and tests/test_env_on.py passes too. I checked that main's readme still has the form feed: line 839 reads work^Lfx-sdk in cat -A, so the readme fix is still needed.
The new log line at MainWindow.xaml.cs:1012 fires only in Run when the tick is on, fsr is false and the license wasn't accepted. That is exactly the legacy-tick case, where StartBuild passes --fsr without the fetch. With #2591 on top, UpdateBuild also passes --fsr for a saved tick without the license, and the message still fits that path. It merges cleanly with #2591 and #2565 in either order.
The red jobs are test_env_on (HOS_FPS_LOG, fixed on main since), test_psychov35 and test_pcache_header_read on Windows. None of them touch the Builder, so a re-run should turn them green.
Follow-up to #1866's review.
HOOKSHOT_FFX_SDKfolder readwork<0x0C>fx-sdk(a\fhad turned into a form feed). It readswork/ffx-sdknow.tests/test_ffx_sdk.py's source check covers the line.Ran locally on Windows:
test_ffx_sdk,test_make_game_ngx,test_builder_dlss_updateanddotnet buildof the Builder, all passing.🤖 Generated with Claude Code