Skip to content

fix(builder): Windows keeps NVIDIA's license accepted in its settings, so an update keeps DLSS without the SDK's files - #2528

Merged
hckrman101 merged 1 commit into
NotRexed:mainfrom
LNDF:windows-dlss-license
Nov 11, 2026
Merged

hckrman101 merged 1 commit into
NotRexed:mainfrom
LNDF:windows-dlss-license

Conversation

@LNDF

@LNDF LNDF commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

On Windows, an update can drop DLSS from a game built with it: both builders use the DLSS SDK's LICENSE.txt as the record that you accepted NVIDIA's license, so if the SDK's files are gone (deleted, a new builder folder) and DLSS isn't ticked in the saved settings, the update builds without DLSS and its runtime is removed. This is the Windows side of #2485, which fixed the same for the Linux builder (pointed out in its review).

What changed

  • builder-settings.json gets DlssLicense, set when the DLSS tick's license is accepted. Both builders read and keep it (the file is shared between the WPF builder and builder/py).
  • An update keeps a folder's DLSS when its runtime is there and DlssLicense is set, or, for a license accepted before this change, when the SDK's LICENSE.txt is there (as before, so nobody loses DLSS on the switch).

Testing

  • tests/builder_dlss_update_test.cs: new cases, the record without the SDK keeps DLSS. Run here on .NET 10 (the PC has no .NET 8 packs; the fixture targets 8): 63 assertions pass, and the new case fails on main's UpdateBuild.
  • tests/test_builder_py_dlss_update.py (new): the Python builder's update decision, taken from its source and run with stand-ins. Passes, and fails on main's update_build.
  • python -I -B tests/run_all.py on Linux: nothing new fails (the three failures there also fail on main).
  • Not run in either builder's UI.

🤖 Generated with Claude Code

…, so an update keeps DLSS without the SDK's files

Both Windows builders (WPF and builder/py) took the DLSS SDK's LICENSE.txt
as the record that the player accepted NVIDIA's license: with the SDK's
files gone (deleted, a new builder folder), an update of a folder built
with DLSS built it without, and its runtime went. NotRexed#2485 fixed the same for
the Linux builder.

- builder-settings.json gets DlssLicense, set when the DLSS tick's license is
  accepted, kept by both builders (the file is shared).
- An update keeps a folder's DLSS when its runtime is there and DlssLicense
  is set, or, for a license accepted before the record, the SDK's
  LICENSE.txt is there.
- tests/builder_dlss_update_test.cs: the record without the SDK keeps DLSS.
  tests/test_builder_py_dlss_update.py (new): the Python builder's update
  decision, run from its source.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@ghost ghost left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The fix does what the description says: both update paths keep DLSS when the runtime is in the folder and either DlssLicense is set or the old LICENSE.txt is there, so nobody loses DLSS on the switch. The record is set only when the license dialog is accepted, and the Python builder keeps it when it rewrites the shared settings file (its save_settings writes only the keys it is given, so that or core.load_settings() fallback is needed, good). The new tests cover the no-SDK case in both builders.

CI: the only red job is test_psychov35.py on windows part 2/2 (scanf deprecated under -Werror in its fixture), unrelated to this PR's files. The ubuntu part 2/2 and the title check were still pending when I looked.

Nits only, see the inline one. Also dlssLicense (the field) sits next to the existing DlssLicense string constant (the dialog text) in the same class; it compiles, but the names are easy to confuse.


/// NVIDIA's license accepted on the DLSS tick, kept in the settings (DlssLicense): an update keeps a folder's DLSS by it.
/// It was the SDK's LICENSE.txt, a download: with the SDK gone, the update built without DLSS and its runtime went
bool dlssLicense;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: this comment stops mid-sentence ("...and its runtime went"), the end of it is missing.

@hckrman101
hckrman101 merged commit b56bf07 into NotRexed:main Nov 11, 2026
12 of 13 checks passed
Fanatrick pushed a commit to Fanatrick/Hookshot that referenced this pull request Nov 12, 2026
198 commits behind: the portable installations (NotRexed#2367), the update guard for a
folder newer than the latest release (NotRexed#2519) and the builder's update fixes
since (NotRexed#2141, NotRexed#2449, NotRexed#2528) all touch the files this branch changes.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DBGH7x7hn8ibuEU45oPKo2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant