Skip to content

test: fix main's three red checks (fixture fopen deprecation; DLSS toggle stub lacks switching; actionlint SC2012) - #2092

Merged
NotRexed merged 2 commits into
mainfrom
fix/main-red-tests
Nov 11, 2026
Merged

NotRexed merged 2 commits into
mainfrom
fix/main-red-tests

Conversation

@NotRexed

@NotRexed NotRexed commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

Main has been red since #2046 and the builder track switch landed:

  • tests/test_pipeline_state_portable.py (Windows): the fixture compiles with `-Werror` and clang on Windows marks `fopen` deprecated. It now passes `-D_CRT_SECURE_NO_WARNINGS`, as the other fixture tests do.
  • tests/test_make_game_ngx.py (all OSes): `Builder.apply_mode` now calls `self.switching()`, and the test's stub had none. It gets `switching=lambda: False`.
  • .github/workflows/linux-appimage.yml (actionlint, from ci: cache the AppImage's back-end objects for pull requests, and a lighter deps cache #2079): the object count used ls | wc -l (shellcheck SC2012). It counts with a glob array, as the loop above it already does.

Checked locally: both pass (fixture built with clang++ and Vulkan headers 1.4.345; test_make_game_ngx 17 tests OK). Unblocks #1999 and the other open PRs.

🤖 Generated with Claude Code

NotRexed and others added 2 commits November 10, 2026 21:15
…the DLSS toggle stub lacks switching)

tests/test_pipeline_state_portable.py compiles its fixture with -Werror, and Windows' clang marks fopen deprecated: add -D_CRT_SECURE_NO_WARNINGS as the other fixture tests do. tests/test_make_game_ngx.py's stub Builder had no switching(), which apply_mode now calls: give it one that says no track switch.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… SC2012)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@NotRexed NotRexed changed the title test: fix main's two red checks (fixture fopen deprecation; DLSS toggle stub lacks switching) test: fix main's three red checks (fixture fopen deprecation; DLSS toggle stub lacks switching; actionlint SC2012) Nov 11, 2026
@NotRexed
NotRexed merged commit e3b1964 into main Nov 11, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant