Repository navigation
test: the finish checks give the build its arguments, read since #1866 - #2102
Closed
jarynclouatre wants to merge 1 commit into
Closed
jarynclouatre wants to merge 1 commit into
jarynclouatre wants to merge 1 commit into
Conversation
…exed#1866 Main is red on every OS since NotRexed#1866: the end of make_game.py's build now reads the build's arguments (fsr_wanted(a, out)) to decide whether AMD's FSR 4 runtime goes beside the game, and the two checks that run that part of the real build, tests/test_finish_output.py and tests/test_linux_update.py, had no "a" to give it: NameError: name 'a' is not defined, in five cases of the first and one of the second. Both now pass the arguments of a build without AMD FSR 4, so the same lines run as before and the new one takes its "not asked for" branch.
This was referenced Nov 11, 2026
Collaborator
|
Heads-up: this conflicts with main now. Could you rebase onto main and resolve the conflicts? Thanks! |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's checks are red on every OS since #1866. The end of
make_game.py's build now reads the build's arguments (fsr_wanted(a, out)) to decide whether AMD's FSR 4 runtime goes beside the game. The two checks that run that part of the real build,tests/test_finish_output.pyandtests/test_linux_update.py, have noato give it:NameError: name 'a' is not defined, in five cases of the first and one of the second.Both now pass the arguments of a build without AMD FSR 4, so the same lines run as before and the new one takes its "not asked for" branch. #2092 does not touch these two files.
Testing (Linux): both tests fail on f915af9 with the NameError and pass with this change.