Repository navigation
tests: fix four source checks broken on main (PREPARE fixture; ini_key renames; long-path out-of-space folder; DrawParameters Ctx) - #1793
Conversation
…eys read ini_key's own renames Main's Python source checks failed on both since today's merges: - test_lift_cleanup_error runs make_game.py's say()/fail() in its own namespace, and say() now reads PREPARE (#1102's --prepare): NameError. The fixture gives it PREPARE=False, its value at the start. - test_recomplauncher_json allowed only output_res as a row whose saved key is not its name; ini_key also saves resolution, upscaling and dlss, and the manifest uses the first two. The test now reads those renames from ini_key. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Verified 172d56c in a clean detached worktree on Windows 11 / Python 3.14.7:
These address the same PREPARE and saved-key failures in the source checks on our rebased PRs. The |
|
One additional Windows baseline failure on main Correction to my original note: this records I am leaving that fix with the current main/CI owners to avoid a duplicate. My masked-clear candidate adds no failure relative to that baseline (267 passed/5 failed/20 skipped versus266/5/20 on Windows). |
…path (#1497 extracts through \?\ paths) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Tested both commits from this PR on main Combined source CI: Windows source checks, native F2I lowering, SPIR-V lowering and actionlint passed. Ubuntu finished with 289 passed, 1 failed, 9 skipped. The three fixtures fixed here and both renderer fixtures pass. The remaining Ubuntu failure is |
…reads it since the mesh fallback skips a task's DrawIndex) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e-ini-keys # Conflicts: # tests/test_lift_cleanup_error.py # tests/test_recomplauncher_json.py
|
One new main CI fixture issue after #1839: on exact main Complete local main suite:290 passed/4 failed/20 skipped; the other three failures are the already recorded NUP path/disk-usage and local SDK limitations. The same four occur on our candidate, so this is baseline scope. Sharing with the existing CI-repair thread rather than mixing it into a renderer feature. No warning/assertion suppression proposed. |
…s harness), skipped on Windows Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…mage's end since present ahead Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Updated onto main (19:00Z, after #1858). Main has since fixed test_lift_cleanup_error and test_recomplauncher_json on its own, so those are taken as main has them. This PR now fixes the four tests still failing on main:
|
nx2/test_draw_parameters.py: main's own fix (NotRexed#1793) replaces this branch's one-line fixture fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Main's Python source checks fail on two tests since today's merges. Every open PR's run shows it, #1625 included:
test_lift_cleanup_error: it runsmake_game.py'ssay/failin its own namespace.say()now reads the globalPREPARE(feat: RecompLauncher support (recomplauncher.json, make_game --game/--prepare) #1102's--prepare), which raisesNameError: name 'PREPARE' is not defined. The fixture now definesPREPARE=False, its value at the start.test_recomplauncher_json: it only allowedoutput_resas a row whose saved key isn't its name.ini_keyalso savesresolution(Render resolution),upscaling(Upscaler) anddlss, and the manifest usesresolutionandupscaling. The test now reads those renames fromini_keyitself.Tests only, no product change. Both pass locally on main d71739d.
🤖 Generated with Claude Code